Skip to content

If vscode folder exists, fetch updates not invoke clone - #19

Merged
stripedpajamas merged 1 commit into
VSCodium:masterfrom
huksley:master
Sep 20, 2018
Merged

stripedpajamas merged 1 commit into
VSCodium:masterfrom
huksley:master

Conversation

@huksley

@huksley huksley commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@huksley huksley changed the title If vscode exists, fetch updates If vscode folder exists, fetch updates not invoke clone Sep 19, 2018
@stripedpajamas

Copy link
Copy Markdown
Member

Hi @huksley, thank you so much for the PR. Can you explain the purpose? I thought every build on Travis was in a fresh container, so would the vscode folder ever already exist?

@huksley

huksley commented Sep 20, 2018

Copy link
Copy Markdown
Contributor Author

I will locally rebuild when new version will be available.
I suppose other people will do the same, without using your binaries.
It is actually works wonderfully, thanks @stripedpajamas!

You`ve been mentioned here:
https://lobste.rs/s/2lepmm/you_think_visual_studio_code_binary_you

@stripedpajamas

Copy link
Copy Markdown
Member

Oh I see. I don't see any benefit of this repo if you're building from source yourself... Doing a git pull on Microsoft's repo, checking out the latest tag, and running the one os-specific gulp build task would be a much smaller and simpler shell script than all the stuff we had to cobble together to get Travis doing it.

I'll go ahead and merge anyway since it doesn't hurt anything 👍

@stripedpajamas
stripedpajamas merged commit 606d3f8 into VSCodium:master Sep 20, 2018
PalinuroSec pushed a commit to VSCodium/vscodium.github.io that referenced this pull request May 25, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants