Repository navigation
codium as app executable name instead of vscodium? #36
Description
The titles, names, and executables in the official and OSS versions all are variations of code and code-oss respectively. Maybe we should keep the pattern by making the executable codium? Also I think the Visual Studio name is copyrighted by Microsoft, not sure, but we might as well be careful. Something else I like about the original code executable is that it's very quick to type, enabling commands like code ~/very/big/path feel more fluent and quick.
Activity
JL2210 commentedon Oct 10, 2018
See number #28.
435vic commentedon Oct 10, 2018
I see... Well, that does make sense. Thank you!
drasbeck commentedon Nov 29, 2018
I like the idea of
codiuminstead ofvscodium, because it eases the onboarding of new users.@435vic, if things stay unchanged (and it looks like they do) you could always just create a symlink to
vscodium, calledcodium.JL2210 commentedon Apr 29, 2019
dzmitry-lahoda commentedon Apr 29, 2019
For
pwsh:JL2210 commentedon Apr 29, 2019
stripedpajamas commentedon Apr 29, 2019
I think @dzmitry-lahoda is on Windows @JL2210
bittner commentedon May 28, 2019
Can we reopen this issue? I'd like to fix this problem for everyone.
bittner commentedon May 28, 2019
Personally, I'd like to stick to the pattern that the non-free distribution follows:
codecodiumThat will make it also easier for developers transitioning from VSCode to VSCodium.
Muscle memory is a thing that is hard to overcome.
stripedpajamas commentedon May 28, 2019
All yours @bittner 💙
This is a breaking change, so proceed with caution. Making the change should be simple (change product.json pre-build). I suppose we will need a big notice in the changelog of the next release that lets people know that
vscodiumwill no longer work (and therefore anyone who hasalias code=vscodiumwill break as well). I'm not sure if any extensions are affected. Some extensions try to call the binary itself... I remember this coming up in an issue a couple of weeks ago but I don't recall where it ended up.bittner commentedon May 29, 2019
Cool, thank you!
I'm not totally sure, but shouldn't it possible to simply change the value for
applicationNamein build.sh? I'll try that in a PR. I hope the build will tell me when things break.Do we have functional tests? I don't see any. We may want to add a simple one (à la "run
codium --version") to thebefore_deploy:block or after calling./build.shin .travis.yml.stripedpajamas commentedon May 29, 2019
Yes that's where the change should be made -- that's the part that updates the product.json file right before building.
bittner commentedon Jun 12, 2019
Everyone looking into upgrading your
vscodiumpackage, please read my hints in the PR. 👀Thanks @stripedpajamas and @paulcarroty! 🥇 🥂 🍾
drasbeck commentedon Jun 13, 2019
Thanks @bittner. 💪
Now I'm happily waiting for this change to silently appear via homebrew.