Skip to content

feat!: Remove deprecated APPETITIVE and AVERSIVE sensory module aliases - #98

Merged
chrisjz merged 1 commit into
mainfrom
chore/remove-deprecated-sensory-aliases
Mar 31, 2026
Merged

feat!: Remove deprecated APPETITIVE and AVERSIVE sensory module aliases#98
chrisjz merged 1 commit into
mainfrom
chore/remove-deprecated-sensory-aliases

Conversation

@chrisjz

@chrisjz chrisjz commented Mar 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove APPETITIVE and AVERSIVE enum variants from ModuleName
  • Remove their registry alias entries in SENSORY_MODULES
  • Update the one config using them (qvarcircuit_predators_small_appetitive_aversive_oracle.yml) to canonical names (food_chemotaxis, nociception)

Test plan

  • Pre-commit checks pass
  • All 1945 tests pass (3 alias tests removed)
  • Verified no other configs use the deprecated names

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Refactor
    • Removed legacy module naming conventions (appetitive, aversive). Configuration files and code using these legacy names must be updated to use the current module names (food_chemotaxis, nociception).

Remove the two remaining legacy sensory module name aliases:
- APPETITIVE → FOOD_CHEMOTAXIS
- AVERSIVE → NOCICEPTION

Update the one config that used them
(qvarcircuit_predators_small_appetitive_aversive_oracle.yml) to use
the canonical module names directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65ac8d89-2c2f-43af-9567-8da5d6b89f23

📥 Commits

Reviewing files that changed from the base of the PR and between a829b9d and 832cdd6.

📒 Files selected for processing (3)
  • configs/special/qvarcircuit_predators_small_appetitive_aversive_oracle.yml
  • packages/quantum-nematode/quantumnematode/brain/modules.py
  • packages/quantum-nematode/tests/quantumnematode_tests/brain/test_modules.py
💤 Files with no reviewable changes (2)
  • packages/quantum-nematode/quantumnematode/brain/modules.py
  • packages/quantum-nematode/tests/quantumnematode_tests/brain/test_modules.py

📝 Walkthrough

Walkthrough

This pull request removes deprecated legacy module name aliases from the quantum nematode brain module system. The enum members APPETITIVE and AVERSIVE and their registry mappings are deleted, and the corresponding configuration and tests are updated to reflect these removals.

Changes

Cohort / File(s) Summary
Configuration Update
configs/special/qvarcircuit_predators_small_appetitive_aversive_oracle.yml
Renamed brain module keys from legacy names (appetitive, aversive) to canonical names (food_chemotaxis, nociception).
Module Registry Cleanup
packages/quantum-nematode/quantumnematode/brain/modules.py
Removed ModuleName.APPETITIVE and ModuleName.AVERSIVE enum members and their corresponding SENSORY_MODULES registry wiring.
Test Removal
packages/quantum-nematode/tests/quantumnematode_tests/brain/test_modules.py
Removed three test cases that verified legacy module name aliases and their sensory module mappings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰✨ Old aliases fade away so sweet,
Legacy names meet their defeat!
From appetitive to chemotaxis so fine,
And aversive becomes nociception divine—
The code now cleaner, the names align! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: removing deprecated APPETITIVE and AVERSIVE sensory module aliases, which aligns perfectly with the changeset modifications across configuration, module definitions, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-deprecated-sensory-aliases

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chrisjz chrisjz changed the title Remove deprecated APPETITIVE and AVERSIVE sensory module aliases feat!: Remove deprecated APPETITIVE and AVERSIVE sensory module aliases Mar 31, 2026
@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chrisjz

chrisjz commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chrisjz
chrisjz merged commit d274325 into main Mar 31, 2026
4 checks passed
@chrisjz
chrisjz deleted the chore/remove-deprecated-sensory-aliases branch March 31, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant