Move to Qiskit 2.x - #290
Conversation
|
Warning Review limit reached
Next review available in: 4 minutes Limit details: Youâve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review detailsâïļ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: â Files ignored due to path filters (1)
ð Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `qiskit>=1.0.0,<2.0.0` pin had held the project on 1.4.6. Lifting it to `>=2.0.0,<3.0.0` resolves to 2.5.2 and needs no code changes at all. That is a genuine finding rather than luck. Qiskit 2.0's removals â `BackendV1`, `execute()`, `Instruction.condition` / `c_if`, `QuantumCircuit.qasm()`, the pulse module, opflow, `bind_parameters` â have zero occurrences in this codebase. The API surface actually in use is small and already V2-era: `QuantumCircuit`, `transpile`, `quantum_info.Statevector`, `providers.BackendV2`, `primitives.PrimitiveResult`, `circuit.Parameter`, plus `qiskit_aer.AerSimulator` and the `qiskit_ibm_runtime` Sampler/Service. Whoever kept this current did the migration work in advance. The upgrade also removes an enormous amount of noise: the suite went from 382,356 warnings to 208. Most of the old volume was Qiskit 1.x deprecation warnings firing once per circuit construction, which is also why CI logs were so large. Verified: full suite 4141 passed / 1 skipped / 2 xfailed, the quantum-brain smoke configs (qvarcircuit, qrh, qef, qsnn, crh, qrc) pass, `pre-commit run --all-files` is green including pyright, and the qiskit-2 API surface was import-smoke-tested directly. The nightly benchmark suite is the real regression guard for a quantum-library major bump and is being run separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ef0abc7 to
7d5589e
Compare
Codecov Reportâ All modified and coverable lines are covered by tests. ðĒ Thoughts on this report? Let us know! |
1 participant
The
qiskit>=1.0.0,<2.0.0pin had held the project on 1.4.6. Lifting it to>=2.0.0,<3.0.0resolves to 2.5.2 and needs no code changes at all.Why that isn't luck
I checked every removal in Qiskit 2.0 against the codebase. All zero occurrences:
BackendV1execute()Instruction.condition/.c_if()QuantumCircuit.qasm()qiskit.pulseopflowbind_parameters()The API surface actually in use is small and already V2-era:
QuantumCircuit,transpile,quantum_info.Statevector,providers.BackendV2,primitives.PrimitiveResult,circuit.Parameter, plusqiskit_aer.AerSimulatorand theqiskit_ibm_runtimeSampler/Service. Whoever kept this current did the migration work ahead of time.Unexpected bonus: the warning flood is gone
The suite went from 382,356 warnings to 208. Most of the old volume was Qiskit 1.x deprecation warnings firing once per circuit construction â which is also a good part of why CI logs were so large.
Verification
pre-commit run --all-filesgreen, pyright included.ðĪ Generated with Claude Code