Repository navigation
build: remove NUKE.build - #159
Conversation
NUKE.build lacks support for slnx. So I've opted to remove it for a more simpler solution.
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
| forEach: ["./SnapX.Avalonia", "./SnapX.CLI", "./SnapX.NativeMessagingHost"], | ||
| async(project) => | ||
| { | ||
|
|
There was a problem hiding this comment.
An opening brace should not be followed by a blank line.
| ?? projectName; | ||
|
|
||
| await RunAsync("dotnet", $"publish {project} --configuration Release --nologo -o {outputDir}/{assemblyName} -r {RuntimeInformation.RuntimeIdentifier} -m"); | ||
|
|
There was a problem hiding this comment.
A closing brace should not be preceded by a blank line.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
github-actions
Bot
added
the
documentation
Windows directions specifically say to use build.ps1
…build # Conflicts: # build/Build.cs # build/_build.csproj
|
temporarily archived. It's not going to be archived permanently. |
Temporarily archived means they're going to do something stupid and want attention, thus the temporary archival. Their repository had plenty of commits as of late. It's a move that I want no part in. Normal open source maintainers do not do this. |
Not everything, the only arguments that are still missing are the ones for the install target.
| } | ||
| catch (Exception) { return 1000; } | ||
| } | ||
|
|
There was a problem hiding this comment.
A closing brace should not be preceded by a blank line.
I'm losing sleep.
If I didn't, most distros dotnet-sdk package wouldn't compatible anymore.
build: always install latest .NET version I am referring to commit 8ee45c1
|
Great work, Brycen. Your pull request is merged. |
|
@BrycensRanch if I may also take out my crystal ball for a moment – next Monday you will feel very silly. |
Preface
The purpose of this PR is to remove the dependency on NUKE.Build.
Ever since SnapX started using slnx for a clearer format than
sln, the NUKE.Build tooling has not kept up.That commit led to a massive build failure due to a lack of support. Upon looking further in the NUKE.Build GitHub issues, I saw this.
For me, this was the first time I had seen an OSS maintainer quoting Twitter as a reason to close a legitimate feature request. Since then, I have been silently looking for a way out of using NUKE.build as the build system.
I was considering using
GNU Make; however, it's far removed from the .NET ecosystem. So I chose less integrated solutions in favor of more control. That's where Bullseye & SimpleExec come in.Notes
This PR also removes the dependency on Bash, and instead leans on standard POSIX scripting for
build.sh. However, the targetinstallis still being worked on.This PR has been upgraded from optional to urgent due to the NUKE.Build GitHub repository being archived. Unfortunately with some .NET libraries going commercial as of late, I can only assume the NUKE.Build maintainers thought it was a great idea.
Additional plans
When .NET 10 releases, we will investigate if this feature will assist.
Also, the deprecated
slnfile will be deleted when .NET 10 releases.