Repository navigation
sys_ppu_thread: Fix u64 stack size argument - #17692
Merged
Merged
Conversation
Megamouse
reviewed
Nov 15, 2025
| // Compute actual stack size and allocate | ||
| const u32 stack_size = utils::align<u32>(std::max<u32>(_stacksz, 4096), 4096); | ||
| // 0 and UINT64_MAX both convert to 4096 | ||
| const u64 stack_size = FN(x ? x : 4096)(utils::align<u64>(_stacksz, 4096)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys_ppu_thread_thread_create: stack size is 64-bit long and for the alignment-up, UINT64_MAX is treated ike 0 instead of returning an error code. (and 0 is treated like 4KB)sys_spu_thread_group_createandsys_spu_thread_initialize.