[shinra-electric]

Fixes #17530
Fixes #17597
Fixes #17563
Probably fixes #17587

Testing:
Both x86 and Arm macOS builds should work

• Arm build
• x86 build

Ready for review

[qurious-pixel]

this works better for the final linkage:

# shellcheck disable=SC2155
export LDFLAGS="-L$BREW_X64_PATH/lib -Wl,-rpath,$BREW_X64_PATH/lib,-L$(brew --prefix llvm)/lib/c++"

[shinra-electric]

this works better for the final linkage:

# shellcheck disable=SC2155
export LDFLAGS="-L$BREW_X64_PATH/lib -Wl,-rpath,$BREW_X64_PATH/lib,-L$(brew --prefix llvm)/lib/c++"

Ok, I'll let the CI finish and then make that change.

I left the optimise script there, so I'm not sure if that will cause issues. I'll comment it out if it acts up.
The optimise script leaves a lot of spam in the log, but it's not causing anything to fail.

[shinra-electric]

CI is passing, and the Arm build seems to be working.

The x86 build is passing, but I was not able to run it under Rosetta.
Someone with an Intel Mac needs to confirm if it's working or not.

[shinra-electric]

this works better for the final linkage:

# shellcheck disable=SC2155
export LDFLAGS="-L$BREW_X64_PATH/lib -Wl,-rpath,$BREW_X64_PATH/lib,-L$(brew --prefix llvm)/lib/c++"

The x86 build is failing because the rpath for c++ lib is wrong. Do you think that's related to your change there?
Library not loaded: @rpath/libc++abi.1.dylib

It's found in RPCS3.app/Contents/lib/libc++abi.1.dylib

Edit:
Running otool -L on the exe shows it's looking in Frameworks, not lib
@executable_path/../Frameworks/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0)

Edit 2:
On the Arm build it's in Frameworks

[qurious-pixel]

The x86 build is failing because the rpath for c++ lib is wrong. Do you think that's related to your change there? Library not loaded: @rpath/libc++abi.1.dylib

It's found in RPCS3.app/Contents/lib/libc++abi.1.dylib

It's in Framework too, but that rpath is not correct. it should be @executable_path/../Frameworks/libc++.1.dylib or @executable_path/../lib/libc++.1.dylib, whichever is the correct one.

Maybe it is copying the wrong one in here. I will test on Intel Mac when I have some time.

rpcs3/.ci/deploy-mac.sh

Line 19 in 3c401e7

cp "/usr/local/opt/llvm@$LLVM_COMPILER_VER/lib/c++/libc++abi.1.0.dylib" "rpcs3.app/Contents/lib/libc++abi.1.dylib"

[shinra-electric]

The x86 build is now working.

Ready for review