Repository navigation
rsx: Fix iterating subdraws with mid-range primitive barriers - #17081
Merged
Merged
Conversation
kd-11
marked this pull request as draft
April 23, 2025 00:36
Contributor
Author
|
I see some more issues that need fixing. |
kd-11
marked this pull request as ready for review
April 23, 2025 11:58
|
Crashing has been fixed, but there is that flickering graphics i showed in a video in earlier post that appear as soon as the camera shows the chopper. I checked with a 4 days old build and those were not there. Should i open another ticket? |
Contributor
Author
|
@bigol83 Yes. Also include a video of the issue and steps to recreate it. I wasn't able to see any flickering in the desert opening area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously execute_pipeline_dependencies was the sole consumer of the barrier iterator and advanced it during processing. This works great but when optimizing other routines that might also need to process barriers we end up reading a stale iterator.
Also applies a minor optimization to get rid of some memory allocations which were being done per-draw-call which is not great for performance.
Closes #17079