Repository navigation
RSX: Fix UB in FIFO_control::get_current_arg_ptr() - #16813
Merged
Merged
Conversation
kd-11
reviewed
Mar 7, 2025
| { | ||
| // Return a raw pointer with no limited access | ||
| return {static_cast<const u32*>(vm::base(m_iotable->get_addr(m_internal_get))), 0x10000}; | ||
| constexpr u32 _1m = 0x100000; |
Contributor
There was a problem hiding this comment.
The caller to get_current_arg_ptr should specify the length they wish to consume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If memory was invalid on the next 4 pages, std::span was referencing invalid memory which is undefined behaviour.
Clamp it to the current page or onto the next if it is valid too.