Skip to content

Memory breakpoints - #11814

Merged
Megamouse merged 2 commits into
RPCS3:masterfrom
RipleyTom:NewDebugBranch
Mar 4, 2025
Merged

Megamouse merged 2 commits into
RPCS3:masterfrom
RipleyTom:NewDebugBranch

Conversation

@RipleyTom

@RipleyTom RipleyTom commented Apr 14, 2022 •

Copy link
Copy Markdown
Contributor

For hackers.
image

Edited, -DHAS_MEMORY_BREAKPOINTS=ON needs to be added for the option to be available within the UI.

@Megamouse Megamouse added the HACKERMAN For hackers. label Apr 14, 2022
Comment thread rpcs3/Emu/Cell/PPUInterpreter.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.h Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/Emu/Memory/vm.h Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_handler.h
@Megamouse
Megamouse marked this pull request as ready for review April 14, 2022 21:48
@Megamouse
Megamouse marked this pull request as draft April 14, 2022 21:49
@Megamouse
Megamouse marked this pull request as ready for review April 15, 2022 11:56
@Megamouse
Megamouse marked this pull request as draft April 15, 2022 11:56
@RipleyTom
RipleyTom force-pushed the NewDebugBranch branch 2 times, most recently from 40bd6de to 4801619 Compare April 15, 2022 13:33
@nastys

nastys commented May 24, 2022

Copy link
Copy Markdown
Contributor

Putting invalid characters e.g. OX162CDB3 instead of 0x162CDB3 in the input box for the BPM address causes RPCS3 to crash.

@illusionyy

Copy link
Copy Markdown
Contributor

Adding execution breakpoints while game is running crashes

@RipleyTom

Copy link
Copy Markdown
Contributor Author

Updated and cleaned the PR and it is now meant for merging.
Note that cmake needs to be called with -DHAS_MEMORY_BREAKPOINTS=ON for the option to be available.

Comment thread rpcs3/Emu/Cell/PPUInterpreter.cpp Outdated
Comment thread rpcs3/Emu/Memory/vm.h Outdated
Comment thread rpcs3/rpcs3.vcxproj
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp
Comment thread rpcs3/Emu/Cell/PPUInterpreter.cpp Outdated
@RipleyTom
RipleyTom force-pushed the NewDebugBranch branch 2 times, most recently from 0e92453 to 691eccc Compare March 2, 2025 10:01
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/breakpoint_list.cpp Outdated
Comment thread rpcs3/rpcs3qt/debugger_add_bp_window.cpp Outdated
Comment thread rpcs3/rpcs3qt/debugger_add_bp_window.cpp Outdated
Comment thread rpcs3/rpcs3qt/debugger_add_bp_window.cpp
RPCS3 needs to be compiled with -DHAS_MEMORY_BREAKPOINTS=ON for it to be available
@RipleyTom
RipleyTom marked this pull request as ready for review March 3, 2025 15:55
@Megamouse
Megamouse merged commit 66952fe into RPCS3:master Mar 4, 2025
@VelocityRa

Copy link
Copy Markdown
Member

Unfortunately this doesn't work (for writes) for several instructions: STVX, STVXL, STDBRX, STWBRX, STFSX, STFSUX, STFDX, STFDUX, STHBRX, STFS, STFSU, STFD, STFDU.

Because they write through vm::_ref instead of the vm::write methods.

@Toiseo

Toiseo commented May 23, 2025 •

Copy link
Copy Markdown

@RipleyTom Could you share a build with this flag enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKERMAN For hackers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants