Repository navigation
[rocprofiler-compute] Remove stale Strix Halo roofline comment - #9481
Merged
vedithal-amd merged 1 commit intoJul 30, 2026
Conversation
- The comment claimed roofline is unsupported on Strix Halo (gfx1151), but gfx1151 is in BENCHMARKING_SUPPORTED, so roofline does run on it. Co-Authored-By: Claude Opus 4.8
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a stale comment in OmniSoC_Base.post_profiling() that incorrectly claimed roofline is unsupported on Strix Halo (gfx1151), aligning inline documentation with the existing roofline gating logic (which is based on BENCHMARKING_SUPPORTED).
Changes:
- Removed the âRoofline not supported on Strix Haloâ comment from
post_profiling().
ðĄ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xuchen-amd
approved these changes
Jul 30, 2026
vedithal-amd
merged commit Jul 30, 2026
1e5ee91
into
rocprofiler-compute-develop
40 of 43 checks passed
vedithal-amd
deleted the
users/vedithal-amd/remove-strix-halo-roofline-comment
branch
July 30, 2026 13:32
vedithal-amd
added a commit
that referenced
this pull request
Jul 30, 2026
## Motivation The comment claiming roofline is unsupported on Strix Halo (gfx1151) contradicts the code: gfx1151 is in BENCHMARKING_SUPPORTED, so roofline does run on it. ## Technical Details - Remove the "Roofline not supported on Strix Halo" comment in OmniSoC_Base.post_profiling() ## JIRA ID JIRA ID: N/A ## Test Plan - [x] Comment-only change, no code paths touched ## Test Result - [x] gfx1151 remains in BENCHMARKING_SUPPORTED; roofline behavior unchanged ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
vedithal-amd
added a commit
that referenced
this pull request
Aug 15, 2026
## Motivation The comment claiming roofline is unsupported on Strix Halo (gfx1151) contradicts the code: gfx1151 is in BENCHMARKING_SUPPORTED, so roofline does run on it. ## Technical Details - Remove the "Roofline not supported on Strix Halo" comment in OmniSoC_Base.post_profiling() ## JIRA ID JIRA ID: N/A ## Test Plan - [x] Comment-only change, no code paths touched ## Test Result - [x] gfx1151 remains in BENCHMARKING_SUPPORTED; roofline behavior unchanged ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
vedithal-amd
added a commit
that referenced
this pull request
Aug 16, 2026
## Motivation The comment claiming roofline is unsupported on Strix Halo (gfx1151) contradicts the code: gfx1151 is in BENCHMARKING_SUPPORTED, so roofline does run on it. ## Technical Details - Remove the "Roofline not supported on Strix Halo" comment in OmniSoC_Base.post_profiling() ## JIRA ID JIRA ID: N/A ## Test Plan - [x] Comment-only change, no code paths touched ## Test Result - [x] gfx1151 remains in BENCHMARKING_SUPPORTED; roofline behavior unchanged ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The comment claiming roofline is unsupported on Strix Halo (gfx1151) contradicts the code: gfx1151 is in BENCHMARKING_SUPPORTED, so roofline does run on it.
Technical Details
JIRA ID
JIRA ID: N/A
Test Plan
Test Result
Submission Checklist