Repository navigation
Add a version.json file - #321
Merged
Merged
Conversation
This adds a dedicated json file to set version numbers, here used for the ROCm version, instead of setting it directly in the CMakeLists.txt. This can be more easily consumed by other scripts used in the CI or for packaging.
marbre
force-pushed
the
users/marbre/version_json
branch
from
April 1, 2025 15:01
eec760a to
607f593
Compare
stellaraccident
approved these changes
Apr 1, 2025
| set(ROCM_MAJOR_VERSION 6) | ||
| set(ROCM_MINOR_VERSION 4) | ||
| set(ROCM_PATCH_VERSION 0) | ||
| file(READ ${CMAKE_CURRENT_SOURCE_DIR}/version.json VERSION_JSON_STRING) |
Collaborator
There was a problem hiding this comment.
Maybe put this in a block and don't leak anything but the component variables.
Also some error checking for if the match doesn't succeed.
Member
Author
There was a problem hiding this comment.
Thanks for the suggestions. I added a block and switched back to use the component variables instead of ROCM_VERSION. Furthermore, it is now checked if the match succeeded.
ScottTodd
approved these changes
Apr 1, 2025
* Adds a block * Switches back to use component variables * Adds error checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dedicated json file to set version numbers, here used for the ROCm version, instead of setting it directly in the CMakeLists.txt. This can be more easily consumed by other scripts used in the CI or for packaging.
Progress on #222.