Repository navigation
docs(serve): fix Prettier formatting in the daemon event schema (#13585) - #13587
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Autofix Report: Main CI Prettier Failure (#13585)IssueMain-branch CI run 37583624862 failed at commit ReproductionChecked out the exact failing commit and ran the exact failing CI step. It reproduced immediately: Root Cause
FixApplied No source, test, or configuration files were touched, so no behavioral change, no new guard or branch, and no focused Vitest run or mutation probe applies. No settings source changed; the build's schema regeneration produced no diff. Verification
Focused Vitest runs: N/A (docs-only formatting change; no package source touched). The workflow's independent CI remains the final verification gate. 中文说明Autofix 报告:Main 分支 CI Prettier 检查失败(#13585)问题Main 分支 CI 运行 37583624862 在提交 复现检出确切的失败提交并运行完全相同的 CI 失败步骤,立即复现: 根因
修复对该文件执行了 未触碰任何源码、测试或配置文件,因此无行为变化、无新增守卫或分支,无需运行针对性 Vitest 或变异探针。未改动 settings 源文件;构建过程中的 schema 再生成未产生任何 diff。 验证
针对性 Vitest 运行:不适用(仅文档格式化改动,未触碰任何包源码)。 工作流的独立 CI 仍是最终验证关卡。 🧠 Handled by Qwen Code · model/模型 |
|
Thanks for the PR! Template looks good ✓ Problem: observed, not theoretical — and I confirmed it independently rather than taking the description's word. Main's Direction: aligned. Red main CI poisons every later full-profile run, and a formatting-only repair is the right shape of fix for it. Size: not applicable — one documentation file, +4/−4, no core paths. Approach: minimal and mechanical, exactly what Risk: no elevated risk signals — no high-risk paths touched. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题: 是已观测到的故障,不是理论性加固——而且我没有只信 PR 描述,自己独立核实过。main 分支的 方向: 对齐。main CI 变红会污染后续每一次 full-profile 运行,用纯格式化修复来处理是正确的形态。 规模: 不适用——单个文档文件,+4/−4,未触及核心路径。 方案: 改动最小且机械,正是 风险: 无升级风险信号——未触及高风险路径。 进入代码审查 🔍 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Code review The diff is content-preserving — no wording, no semantics, only Prettier normalization. Two things change in one table, and I checked both against what Prettier actually does rather than assuming. Emphasis: Padding: Prettier pads every cell in a column to I also swept the remaining 365 lines for anything else Prettier would flag in this file: no other single-asterisk emphasis, no other non-uniform table, no trailing whitespace, no tabs, no CRLF, no triple blank lines, file ends with a newline. So the four changed lines are the complete delta and nothing dirty is left behind — the fix should turn the lane green rather than move the warning to the next line. No blockers, no AGENTS.md violations, nothing to simplify. One nit, non-blocking: the description's "fails on every main run since commit CI evidence (unattended run — I did not execute any PR-side code; this is read from the checks on the reviewed commit) The headline is that this PR's green So the evidence for the fix is the static analysis above, not CI. The PR body also states that Sandboxed verification would settle this: Nothing user-visible here, so no terminal capture applies ( Checks on the reviewed commit at review time:
中文说明代码审查 diff 不改变任何内容——没有措辞、没有语义变化,只有 Prettier 规范化。一个表格里有两处变化,两处我都对照 Prettier 的实际行为核实过,而不是想当然。 强调标记: 填充宽度: Prettier 会把某列每个单元格补齐到「该列最长文本宽度 + 2」。main 上 Trigger 列五行互不一致——428(表头)、430(分隔行)、430、432、411 字符——这正是违规点。本分支上五行都是 411,而 411 = 409 + 2,409 就是最长单元格(未被改动的 我还扫了文件其余 365 行,检查 Prettier 可能标记的其他问题:没有其他单星号强调、没有其他宽度不一致的表格、没有行尾空格、没有制表符、没有 CRLF、没有连续三个空行、文件以换行结尾。所以这 4 行改动就是完整增量,文件里没有残留的脏格式——这个修复应该能让该检查项真正变绿,而不是把警告推到下一行。 没有阻塞问题,没有违反 AGENTS.md,也没有可简化的地方。一个小提示(非阻塞):描述里"自提交 CI 证据(无人值守运行——我没有执行任何 PR 侧代码;以下结论来自被审查提交上的检查记录) 关键点是:本 PR 那个绿色的 因此本修复的证据是上面的静态分析,而不是 CI。PR 正文还声明在 runner 检出上运行 沙箱验证可以坐实这一点: 本 PR 没有用户可见变化,因此终端实录不适用( — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Confidence: 4/5 — mechanically correct and verified against Prettier's own formatting rules; the single deduction is that no executed Prettier run backs it, because this PR's CI skips that step. My independent proposal before reading the diff was: run the formatter on that one file, commit exactly the resulting diff, and separately chase down why a green PR was allowed to land unformatted markdown. That is precisely what this PR is, so there is no simpler path I can offer — four lines in one doc file is the floor for repairing a red main. What convinced me is not the green check (which is a no-op here, as Stage 2 explains) but the arithmetic: the repaired table's Trigger column is uniform at 411 chars = the untouched longest cell's 409 + 2, every row totals 511 chars, and a sweep of the rest of the file finds no other emphasis marker, non-uniform table, trailing whitespace, tab, CRLF or blank-line run that Prettier would object to. The change is exactly Prettier's fixed point for this file, so it should clear the lane instead of shifting the warning. If I owned this in six months I would thank the author: the diff is reviewable in ten seconds, it cannot regress runtime behavior, and it unblocks every subsequent full-profile CI run. My one reservation is about the system, not the PR — Approving, pinned to the reviewed commit. 中文说明信心度:4/5 —— 机制上正确,并已对照 Prettier 自身的格式化规则验证;唯一扣分点是没有任何"真正执行过 Prettier"的运行结果作支撑,因为本 PR 的 CI 跳过了该步骤。 在读 diff 之前,我自己的方案是:对那一个文件跑一遍格式化工具,只提交由此产生的 diff,另外去追查为什么一个绿灯 PR 能把未格式化的 markdown 合进来。本 PR 正是这个方案,所以我给不出更简的路径——修一条变红的 main,一个文档文件里的 4 行已经是下限。 真正说服我的不是那个绿色检查(如 Stage 2 所述,它在这里是空跑),而是算术:修复后表格 Trigger 列统一为 411 字符 = 未被改动的最长单元格 409 + 2,每行总长都是 511 字符;对文件其余部分的扫描也没有发现 Prettier 会反对的其他强调标记、宽度不一致的表格、行尾空格、制表符、CRLF 或连续空行。这个改动正是该文件的 Prettier 不动点,所以它应该能让检查真正通过,而不是把警告挪个位置。 如果六个月后由我来维护,我会感谢作者:diff 十秒就能审完,不可能造成运行时回归,并且解除了后续每一次 full-profile CI 运行的阻塞。我唯一的保留意见针对的是机制而非本 PR—— 已批准,并绑定到被审查的提交。 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
|
📄 Docs-only change — the automatic review ran at
Reviewed head: 中文说明📄 纯文档变更 —— 自动评审以 |
|
🤖 Reviewed the latest feedback — no changes needed. Why, point by point: · 已审阅最新反馈——无需改动。逐点说明原因如下: Autofix review round — no action takenFeedback receivedThe only feedback newer than the last evaluation is one issue-level comment from
Independent verification performedSince the Suggestion text is unavailable, the PR's own diff and current state were re-inspected directly:
ConclusionThere is nothing actionable in this round: no Critical or reproduced defect, no failing check, no inline finding to resolve, reply to, decline, or defer. If the unposted Suggestion matters, a maintainer can trigger a high-effort review with 中文说明Autofix 评审轮次 —— 未做任何改动收到的反馈上次评估之后唯一的反馈是
已执行的独立验证由于无法获取该 Suggestion 的文本,本次直接重新检查了 PR 自身的 diff 和当前状态:
结论本轮没有可执行的事项:没有 Critical 或可复现的缺陷,没有失败的检查,也没有需要解决、回复、拒绝或延后的行内发现。如果那条未发布的 Suggestion 确实重要,维护者可以按 bot 评论中的提示用 Base-conflict check · 基分支冲突检查: no conflict with main. · 与 main 无冲突。 🧠 Handled by Qwen Code · model/模型 |
|
Released in v0.25.1. |
What this PR does
This PR applies Prettier formatting to
docs/developers/daemon/09-event-schema.md, the daemon event-schema doc whose pending-prompt queue table currently violates the repository's Prettier rules. The change is purely mechanical: asterisk emphasis (*genuinely queued*) is normalized to underscores (_genuinely queued_) and the surrounding table column padding is adjusted to match. Four lines change in a single table; no wording, code, or configuration is modified.Why it's needed
Main-branch CI is red. The
Lint & Staticjob'sRun Prettierstep (node scripts/lint.js --prettier) fails on every main run since commit1aba19c87889e8bd55f5249b81e21d8de3f056dd, because this file landed without Prettier's emphasis-marker normalization. Until it is fixed, every subsequent main CI run fails in the lint stage before tests are even reported. Tracked in #13585.Reviewer Test Plan
How to verify
mainat1aba19c878, runnode scripts/lint.js --prettier— it reports[warn] docs/developers/daemon/09-event-schema.mdand exits non-zero.All matched files use Prettier code style!and exits zero.*genuinely queued*becoming_genuinely queued_.Evidence (Before & After)
N/A — non-UI docs formatting change.
Tested on
Environment (optional)
Verified on the GitHub Actions runner checkout (Ubuntu, Node 22.x):
node scripts/lint.js --prettier,npm run build,npm run typecheck, andnpm run lintall pass.Risk & Scope
Linked Issues
Fixes #13585
中文说明
本 PR 做了什么
本 PR 对
docs/developers/daemon/09-event-schema.md应用 Prettier 格式化——该 daemon 事件 schema 文档中的 pending-prompt 队列表格当前违反了仓库的 Prettier 规则。改动纯属机械性:星号强调(*genuinely queued*)被规范化为下划线(_genuinely queued_),周围表格列的填充宽度随之相应调整。仅单个表格中的 4 行发生变化;未修改任何措辞、代码或配置。为什么需要
Main 分支 CI 处于红色失败状态。自提交
1aba19c87889e8bd55f5249b81e21d8de3f056dd起,Lint & Static任务的Run Prettier步骤(node scripts/lint.js --prettier)在每次 main 运行中都失败,因为该文件合入时未完成 Prettier 的强调标记规范化。在修复之前,后续每次 main CI 运行都会在 lint 阶段失败,甚至来不及报告测试结果。跟踪于 #13585。审查者测试计划
如何验证
main的1aba19c878提交上运行node scripts/lint.js --prettier——会报告[warn] docs/developers/daemon/09-event-schema.md并以非零码退出。All matched files use Prettier code style!并以零码退出。*genuinely queued*变为_genuinely queued_外无其他变化。前后对比证据
N/A —— 非 UI 的文档格式化改动。
已测试平台
环境(可选)
在 GitHub Actions runner 检出环境(Ubuntu,Node 22.x)上验证:
node scripts/lint.js --prettier、npm run build、npm run typecheck和npm run lint全部通过。风险与范围
关联 Issue
Fixes #13585