Print pcre2test output in colour. - #811
Merged
Merged
Conversation
IsaacOscar
force-pushed
the
pcre2test_colour
branch
3 times, most recently
from
October 4, 2025 16:11
06318ae to
6539820
Compare
This commit makes various changes to to pcre2test to support colourising the output, in particular, the following colour scheme is intended: * Comments from the inputfile are in grey (but not those entered in interactively) * All other input is in green * Messages related to PCRE2 api errors are in magenta * Messages related to errors with using pcre2test itself are in red * Timing and memory usage information is in blue * Normal output is in your terminal's default foreground colour * The interactive prompt is in blue * Anything withought an explicit colour set (e.g. stuff printed by valgrind) should be in yellow
This finishes of the work started by the previous commit.
IsaacOscar
force-pushed
the
pcre2test_colour
branch
from
October 4, 2025 16:18
6539820 to
49735a3
Compare
Member
|
This is great! I have a few requests:
|
NWilson
approved these changes
Oct 10, 2025
NWilson
left a comment
Member
There was a problem hiding this comment.
I've made those changes. I'll merge it soon, unless you message to say there are additional changes you'd like to make.
Thank you very much Isaac!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
-coption topcre2testthat will print various different output in colour.For ease of reviewing I've split the changes into two commits:
printf,pchars, etc. calls to also include the colour to use.Most output from
pcre2testis given an explicit colour, however this is often justclr_outputwhich is the terminals default colour (i.e. it likely won't be in "colour").