Skip to content

Audio Files should have NO image data (allowing lower layers to show through) - #921

Merged
jonoomph merged 1 commit into
developfrom
audio-background-transparent
Apr 16, 2023
Merged

jonoomph merged 1 commit into
developfrom
audio-background-transparent

Conversation

@jonoomph

Copy link
Copy Markdown
Member

Small refactor to ensure that audio files have no image data - and allow videos below them to show through...

@jonoomph

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented Apr 16, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #921 (89714b6) into develop (b21a686) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #921      +/-   ##
===========================================
- Coverage    54.21%   54.19%   -0.02%     
===========================================
  Files          190      190              
  Lines        16592    16599       +7     
===========================================
+ Hits          8995     8996       +1     
- Misses        7597     7603       +6     
Impacted Files Coverage Δ
src/Clip.h 68.75% <ø> (ø)
src/effects/Caption.cpp 0.00% <0.00%> (ø)
src/FrameMapper.cpp 92.13% <50.00%> (ø)
src/Clip.cpp 69.74% <83.33%> (-0.05%) ⬇️
src/Timeline.cpp 55.84% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph
jonoomph merged commit 5174608 into develop Apr 16, 2023
@jonoomph
jonoomph deleted the audio-background-transparent branch April 16, 2023 16:46
@dahu1985

dahu1985 commented Apr 17, 2023 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants