Repository navigation
fix(s6): clear stale log lock before startup - #46289
Merged
Merged
Conversation
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
✅ Fixed issues (2):
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
run_agent.py:2920: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
Unchanged: 5734 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
alt-glitch
added
type/bug
# Conflicts: # scripts/release.py
# Conflicts: # scripts/release.py
alanbratu
pushed a commit
to alanbratu/hermes-agent
that referenced
this pull request
Jun 17, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
Methodician
added a commit
to Methodician/hermes-agent
that referenced
this pull request
Jul 4, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
fsca8
pushed a commit
to fsca8/hermes-agent
that referenced
this pull request
Oct 6, 2026
* fix(cli): clear stale s6-log lock file before startup on virtiofs * chore(release): map salvaged contributor --------- Co-authored-by: zxcasongs <35259607+zxcasongs@users.noreply.github.com> Co-authored-by: Ben <ben@nousresearch.com>
alt-glitch
added
area/install-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S6 gateway startup now clears stale
s6-loglock files before launching, preventing virtiofs-backed containers from getting stuck in a logger startup loop.Changes
hermes_cli/service_manager.py: clears the stale log lock file before service startup.Validation
python3 -m pytest tests/hermes_cli/test_service_manager.py -q -o addopts=''python3 -m py_compile hermes_cli/service_manager.py ...git diff --checkSalvages #41712 with @zxcasongs's authorship preserved.
Infographic