Repository navigation
fix(langfuse): redact base64 data URIs instead of truncating into invalid base64 - #43322
Merged
kshitijk4poor merged 1 commit intoJun 10, 2026
Conversation
…alid base64 The Langfuse SDK treats `data:*;base64,...` strings as media and tries to decode them. `_truncate_text` was slicing those strings mid-payload, producing invalid base64 and noisy "Error parsing base64 data URI" logs. Observability only needs the metadata, not raw image/audio bytes, so redact the whole data URI (type, media_type, length) before it reaches the SDK. Salvaged the Langfuse fix from NousResearch#39682 onto current main as a standalone, single-concern change (the dashboard `dist/**` and plugin-discovery parts of that PR already landed separately on main). Co-authored-by: foras910521-lab <foras910521-lab@users.noreply.github.com>
alt-glitch
added
type/bug
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
…64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
fsca8
pushed a commit
to fsca8/hermes-agent
that referenced
this pull request
Oct 6, 2026
…-redact-base64-data-uri fix(langfuse): redact base64 data URIs instead of truncating into invalid base64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redact base64
data:URIs in the Langfuse plugin instead of truncating them into invalid base64 payloads.The Langfuse SDK treats
data:*;base64,...strings as media and attempts to decode them._truncate_textwas slicing those strings mid-payload, producing invalid base64 and noisyError parsing base64 data URIlogs. Observability only needs the metadata (type, media type, length), not the raw image/audio bytes — so the whole data URI is redacted before it reaches the SDK.Context
This is a single-concern salvage of one part of #39682, lifted onto current
main. The other concerns in that PR are already resolved upstream:dist/**asarUnpack — already onmain(53a2ac8f2).plugins list/ dashboard hub — already onmainvia fix(plugins):hermes plugins listdoes not discover nested category plugins #41066 (ccacfdbd6) + follow-up2b89afec7, and that PR's version had diverged to an incompatible tuple shape.The
skill_viewfrontmatter-name fix from #39682 is sent separately.Test Plan
TestPayloadSanitization: base64 data URI is redacted to{type, media_type, omitted, length}instead of truncated, both as a bare value and insideimage_urlmessage parts).ruff checkclean on touched files.Co-authored-by: foras910521-lab foras910521-lab@users.noreply.github.com