Stop scheduler on StatelessRegistry close - #1259
Merged
Merged
Conversation
StatelessRegistry started a publishing Scheduler in start() and shut it down only in stop(), but did not override close(). The inherited AbstractRegistry.close() cleared the meters but left the scheduler thread running, so closing the registry leaked the spectator-reg-stateless thread (and skipped the final flush), unlike AtlasRegistry whose close() calls stop(). Override close() to stop() the scheduler and then super.close() to release the remaining state, mirroring AtlasRegistry. Adds tests that the scheduler thread is stopped after close() and that closing a never-started registry does not throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatelessRegistry started a publishing Scheduler in start() and shut it down only in stop(), but did not override close(). The inherited AbstractRegistry.close() cleared the meters but left the scheduler thread running, so closing the registry leaked the spectator-reg-stateless thread (and skipped the final flush), unlike AtlasRegistry whose close() calls stop().
Override close() to stop() the scheduler and then super.close() to release the remaining state, mirroring AtlasRegistry. Adds tests that the scheduler thread is stopped after close() and that closing a never-started registry does not throw.