Skip to content

one hyper-parameter representation error #31

Closed

Description

@zhuixunforever

In Hyperparameter saysbeta is the initial value of Beta in Eq. 3 of the paper.
but in code, beta seem to be 'gamma' of absolute pose, and gamma seem to be 'gamma' of relative pose.
In train.py:

saq = section.getfloat('beta')
srq = section.getfloat('gamma')

In common/criterion.py:

#absolute pose loss
abs_loss =
torch.exp(-self.sax) * self.t_loss_fn(pred.view(-1, *s[2:])[:, :3],
targ.view(-1, *s[2:])[:, :3]) +
self.sax +
torch.exp(-self.saq) * self.q_loss_fn(pred.view(-1, *s[2:])[:, 3:],
targ.view(-1, *s[2:])[:, 3:]) +
self.saq
#VO loss
vo_loss =
torch.exp(-self.srx) * self.t_loss_fn(pred_vos.view(-1, *s[2:])[:, :3],
targ_vos.view(-1, *s[2:])[:, :3]) +
self.srx +
torch.exp(-self.srq) * self.q_loss_fn(pred_vos.view(-1, *s[2:])[:, 3:],
targ_vos.view(-1, *s[2:])[:, 3:]) +
self.srq

Activity

  1. samarth-robo commented on Jan 3, 2020

    @samarth-robo
    Contributor

    Hi @zhuixunforever you are right, thanks for pointing it out. Fixed in 6b35018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions