Skip to content

[REQ] Add upper Cholesky factorization support to tile operations #1318

Description

@adenzler-nvidia

Summary

Add a fill_mode parameter to wp.tile_cholesky(), wp.tile_cholesky_inplace(), wp.tile_cholesky_solve(), and wp.tile_cholesky_solve_inplace() to support upper-triangle Cholesky factorization and solve alongside the existing lower-triangle default.

Motivation

The current lower-triangle Cholesky reads columns sequentially, which causes shared memory bank conflicts at power-of-2 tile sizes. Upper-triangle Cholesky reads rows instead, eliminating these conflicts and improving performance:

  • 1.23x–1.70x speedup in microbenchmarks at power-of-2 tile sizes (RTX PRO 6000 Blackwell)
  • 2.7–3.1% wall-clock improvement in MuJoCo three_humanoids simulation (nworld=8192)

Proposed API

# Lower Cholesky (unchanged default)
L = wp.tile_cholesky(A)                                                                                                                                                                                          
x = wp.tile_cholesky_solve(L, y)                                                                                                                                                                                 
                                                                                                                                                                                                                   
# Upper Cholesky (new)                                                                                                                                                                                           
U = wp.tile_cholesky(A, fill_mode="upper")
x = wp.tile_cholesky_solve(U, y, fill_mode="upper")                                                                                                                                                              
  
fill_mode is a compile-time constant string ("lower" or "upper"), following the same                                                                                                                             
pattern as wp.tile_sum(a, axis=...).

Activity

  1. added this to the 1.13.0 milestone on Mar 25, 2026
  2. shi-eric commented on Mar 31, 2026

    @shi-eric
    Contributor

    Added in 0cda7e1

    I believe @daedalus5 has some follow-up items regarding variable naming and deprecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

feature requestRequest for something to be addedtileTile programming model

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions