Repository navigation
Sync the vendored RAPIDS.cmake with rapids-cmake release/25.12 - #466
oleksandr-pavlyk merged 1 commit into
Conversation
The vendored copy still defaulted to the branch-XX.YY naming. rapids-cmake has since moved its release branches to release/XX.YY, and GitHub now redirects branch-25.12 to main. NVBench therefore fetched rapids-cmake main instead of 25.12, and main requires CMake 4.0, so configuring with the documented CMake 3.30.4 or any 3.x failed. The release/25.12 copy of RAPIDS.cmake defaults to release/XX.YY. It differs from the vendored one only in that line and in the license header. Fixes NVIDIA#465
|
/ok to test 652a5a3 |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe version-derived RAPIDS.cmake branch now uses ChangesRAPIDS.cmake version selection
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesPriority: ⬆️ High Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The release branch resolves through the configured fetch paths, and no actionable merge-blocking risk is established by these changes.
Comment ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
|
Fixes #465.
Configuring with any CMake 3.x currently fails, although the README and
cmake_minimum_requiredsay 3.30.4:The vendored
cmake/RAPIDS.cmaketurns the requested version into the branch namebranch-25.12. rapids-cmake has moved its release branches torelease/XX.YY, and GitHub now redirectsbranch-25.12tomain: the archive URL answers with a 302 to.../zip/main. So NVBench has been building against rapids-cmakemainrather than 25.12, andmainrequires CMake 4.0.rapids-cmake's own
release/25.12copy ofRAPIDS.cmakealready defaults torelease/${rapids-cmake-version}. It differs from the vendored file only in that line and in the license header, so this syncs the vendored copy with it. I also updated the download URL in the comment inNVBenchRapidsCMake.cmake, which pointed at the old branch name.Testing
In
nvidia/cuda:12.9.1-devel-ubuntu24.04with CMake 3.31.10 and-DCMAKE_CUDA_ARCHITECTURES=90(no GPU):nvbenchtarget builds and linksConfiguring with CMake 4.3.2 gets past rapids-cmake as well, so newer CMake is not affected.