Repository navigation
pre-commit: Update isort version to 5.12.0 - #12645
Merged
raydouglass merged 1 commit intoJan 30, 2023
Merged
Conversation
poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.
wence-
added
tests
shwina
approved these changes
Jan 30, 2023
galipremsagar
added
the
5 - Ready to Merge
Contributor
Author
|
/merge |
shwina
removed
the
! - Hotfix
Contributor
|
(not a hotfix, as cuDF freezes EOD today) |
msadang
approved these changes
Jan 30, 2023
msadang
left a comment
msadang
left a comment
Contributor
There was a problem hiding this comment.
Revision changes looks good.
This was referenced Jan 31, 2023
rapids-bot Bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Feb 1, 2023
Poetry version 1.5.0 broke installs of `isort` prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078). This is fixed in 5.12.0. xref: NVIDIA/cudf#12645
rapids-bot Bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Feb 1, 2023
Poetry version 1.5.0 broke installs of `isort` prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078). This is fixed in 5.12.0. xref: NVIDIA/cudf#12645 Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - https://github.com/jakirkham - Gregory Lee (https://github.com/grlee77) URL: #492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.
Checklist