Skip to content

Fixes for tensornet backend not picking up MPI - #974

Merged
1tnguyen merged 5 commits into
NVIDIA:mainfrom
1tnguyen:tnguyen/tensornet-mpi-reset
Dec 1, 2023
Merged

Fixes for tensornet backend not picking up MPI#974
1tnguyen merged 5 commits into
NVIDIA:mainfrom
1tnguyen:tnguyen/tensornet-mpi-reset

Conversation

@1tnguyen

Copy link
Copy Markdown
Collaborator

Description

The tensornet backend propagates MPI to cutensornet lib during ctor. However, the static instance might be created before MPI initialization; hence need to be reset to pick up MPI and propagate to cutensornet.

The tensornet backend propagates MPI to cutensornet during ctor. However,
the static instance might be created before MPI initialization; hence
need to be reset to pick up MPI and propagate to cutensornet.
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 29, 2023

@schweitzpgi schweitzpgi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread runtime/nvqir/cutensornet/simulator_tensornet_register.cpp
Comment thread runtime/nvqir/cutensornet/simulator_tensornet_register.cpp Outdated
Comment thread runtime/nvqir/cutensornet/simulator_tensornet_register.cpp
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 30, 2023
@github-actions

github-actions Bot commented Dec 1, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Dec 1, 2023
@1tnguyen
1tnguyen merged commit 71b3d16 into NVIDIA:main Dec 1, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim changed the title Fixes for tensornet backend may not pick up MPI Fixes for tensornet backend not picking up MPI Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants