Added missing GIL-safe implementation for pySampleAsync - #828
Merged
Conversation
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Oct 27, 2023
schweitzpgi
approved these changes
Oct 27, 2023
Collaborator
Author
Command Bot: Processing... |
- When using kernel_builder with async. in C++, we may hit thread-safety issue in jit compile. For Python, we pre-jit the kernel on the main thread hence is not affected by this. - Fix issues with get_state_async: missing qpu_id in reset_context and set_current_qpu. - Update comments.
1tnguyen
force-pushed
the
tnguyen/issue-640
branch
from
October 30, 2023 05:14
b96ed36 to
437ee6f
Compare
Collaborator
Author
|
I've updated this PR to add some more fixes also related to async. execution. Please help re-review it. |
Collaborator
Author
Command Bot: Processing... |
Collaborator
Author
Command Bot: Processing... |
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
approved these changes
Oct 30, 2023
amccaskey
left a comment
amccaskey
left a comment
Collaborator
There was a problem hiding this comment.
new changes look good to me
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converting Python args to native data before passing it to the async sample functor. We've implemented it for
observe_async, hence adopting it forpySampleAsync.Addressed #640.