Correctly distinguish measurement result and boolean variable - #1952
Merged
Conversation
khalatepradnya
added
bug fix
khalatepradnya
commented
Jul 17, 2024
khalatepradnya
marked this pull request as draft
July 17, 2024 21:10
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
khalatepradnya
force-pushed
the
fix-bool-scope
branch
2 times, most recently
from
July 17, 2024 22:34
997ca6c to
5fb5e4e
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
as regular variable. * Towards fixing issue#1777
* Wrap the kernel in test function
khalatepradnya
force-pushed
the
fix-bool-scope
branch
from
July 17, 2024 23:42
049d8a7 to
0d8027c
Compare
khalatepradnya
marked this pull request as ready for review
July 17, 2024 23:45
schweitzpgi
reviewed
Jul 18, 2024
schweitzpgi
reviewed
Jul 18, 2024
Comment on lines
+59
to
+60
| # CHECK: %[[VAL_18:.*]] = cc.alloca !cc.stdvec<i1> | ||
| # CHECK: cc.store %[[VAL_17]], %[[VAL_18]] : !cc.ptr<!cc.stdvec<i1>> |
Collaborator
There was a problem hiding this comment.
This code doesn't create a vector, doesn't create any storage to save a vector's data, doesn't copy the vector, does potentially create a memory leak on the stack, and in the end is a dead store to a memory location that will never be read.
bettinaheim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.