Keep stack from growing without bound - #1892
Merged
Merged
Conversation
This fixes a bug where classical variables may be allocated on the stack without bound. Instead, use the scope information to bound the lifetimes of classical variables and prevent a standard loop from accidentally exhausting the stack. We haven't encountered this issue because we have focused on SCPs and totally unrolling all the loops. This patch is preventative maintenance. Add test.
schweitzpgi
force-pushed
the
ch-tame.stack
branch
from
July 5, 2024 20:57
3fff241 to
095cc9f
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Collaborator
Author
|
ping. needs a review. |
bmhowe23
reviewed
Jul 10, 2024
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
enabled auto-merge (squash)
July 12, 2024 15:34
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where classical variables may be allocated on the stack without bound. Instead, use the scope information to bound the lifetimes of classical variables and prevent a standard loop from accidentally exhausting the stack.
We haven't encountered this issue because we have focused on SCPs and totally unrolling all the loops. This patch is a preventative fix.