Skip to content

Fix bug 1108 - race condition in sample_async - #1114

Merged
amccaskey merged 3 commits into
NVIDIA:mainfrom
amccaskey:fix1108
Jan 23, 2024
Merged

Fix bug 1108 - race condition in sample_async#1114
amccaskey merged 3 commits into
NVIDIA:mainfrom
amccaskey:fix1108

Conversation

@amccaskey

@amccaskey amccaskey commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

Race condition due to non-uniqueness of hash value for storage of opaque arguments in async multi-qpu scenario.

@amccaskey
amccaskey requested a review from 1tnguyen January 19, 2024 13:48
@copy-pr-bot

copy-pr-bot Bot commented Jan 19, 2024

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey

amccaskey commented Jan 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@github-actions

github-actions Bot commented Jan 19, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Jan 19, 2024
@cuda-quantum-bot
Docs preview for PR #1114.
aa37c18
bmhowe23
bmhowe23 reviewed Jan 19, 2024
View reviewed changes
Comment thread python/runtime/cudaq/algorithms/py_sample.cpp Outdated
@amccaskey

amccaskey commented Jan 22, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

github-actions Bot pushed a commit that referenced this pull request Jan 22, 2024
@cuda-quantum-bot
Docs preview for PR #1114.
76b5dfd
@github-actions

github-actions Bot commented Jan 22, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@amccaskey
amccaskey requested a review from bmhowe23 January 22, 2024 13:59
@amccaskey
amccaskey enabled auto-merge (squash) January 22, 2024 14:02
1tnguyen
1tnguyen reviewed Jan 22, 2024
View reviewed changes
Comment thread python/runtime/cudaq/algorithms/py_sample.cpp
1tnguyen
1tnguyen approved these changes Jan 22, 2024
View reviewed changes

@1tnguyen 1tnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amccaskey
Fix bug 1108 - race condition in sample_async
035e7f7 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Update with pr review comments / suggestions
56376fb 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
clean up
5f31398 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey

amccaskey commented Jan 23, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@amccaskey
amccaskey merged commit 4939871 into NVIDIA:main Jan 23, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 23, 2024
@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Jan 25, 2024
@bmhowe23 bmhowe23 added this to the release 0.6.0 milestone Jan 25, 2024
@amccaskey
amccaskey deleted the fix1108 branch February 29, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes
@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

Assignees

No one assigned

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Milestone

release 0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amccaskey @1tnguyen @bmhowe23