Fix failing warning suppression for nvrtc - #5278
Merged
Merged
Conversation
I was pretty sure that NVRTC sets the cuda compiler to NVCC but it does not. We need to properly enable the warning suppression for nvrtc too :(
bernhardmgruber
approved these changes
Jul 16, 2025
Contributor
ðĐ CI finished in 2h 56m: Pass: 100%/205 | Total: 2d 09h | Avg: 16m 53s | Max: 1h 51m | Hits: 89%/338181
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
ðâ Runner counts (total jobs: 205)
| # | Runner |
|---|---|
| 128 | linux-amd64-cpu16 |
| 23 | windows-amd64-cpu16 |
| 14 | linux-amd64-gpu-h100-latest-1 |
| 14 | linux-amd64-gpu-rtxa6000-latest-1 |
| 12 | linux-arm64-cpu16 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.0.x
git worktree add -d .worktree/backport-5278-to-branch/3.0.x origin/branch/3.0.x
cd .worktree/backport-5278-to-branch/3.0.x
git switch --create backport-5278-to-branch/3.0.x
git cherry-pick -x 8759a8305b0705c0a2e216c45c88bb2cb952cd27 |
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Jul 16, 2025
I was pretty sure that NVRTC sets the cuda compiler to NVCC but it does not. We need to properly enable the warning suppression for nvrtc too :(
miscco
added a commit
that referenced
this pull request
Jul 17, 2025
* Enhance our deprecation machinery so that we also suppress the right nvcc warnings (#5138) * Avoid deprecation suppression within a class definition * Rework deprecation machinery to also use the special NVCC deprecation * Fix failing warning suppression for nvrtc (#5278) I was pretty sure that NVRTC sets the cuda compiler to NVCC but it does not. We need to properly enable the warning suppression for nvrtc too :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was pretty sure that NVRTC sets the cuda compiler to NVCC but it does not.
We need to properly enable the warning suppression for nvrtc too :(
Fixes: #5277