do not constexpr cast to enum a value that is outside the enum's range - #4905
Merged
Merged
Conversation
Contributor
🟩 CI finished in 22m 24s: Pass: 100%/30 | Total: 2h 35m | Avg: 5m 11s | Max: 17m 15s | Hits: 97%/15084
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 30)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
Jun 4, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
For older CTK's, cudax's device attributes code defines the following:
the trouble is that that is not actually valid code.
0x8is outside the range of thecudaMemAllocationHandleTypeenum before 12.4. I'm not sure why we are skating by in the tests. maybe it's because we use thesystem_headerpragma.but clangd flags this as broken, which causes most of the cudax headers appear red (as having errors) in vscode when using one of the cuda12.0 devcontainers. and that makes clangd less useful.
i like clangd. i also like conforming code. make the class static an
inline constinstead ofconstexpr.Checklist