[STF] Ensure we generate CUDA graphs which always have the same topology - #4705
Merged
Conversation
âĶlogy so that the update is more likely to succeed
Contributor
Contributor
Author
|
/ok to test f9fd8a9 |
Contributor
Author
|
/ok to test f9fd8a9 |
caugonnet
marked this pull request as ready for review
May 15, 2025 13:10
caugonnet
enabled auto-merge (squash)
May 15, 2025 13:29
Contributor
ðĐ CI finished in 41m 29s: Pass: 100%/26 | Total: 6h 14m | Avg: 14m 23s | Max: 28m 52s | Hits: 67%/14642
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
ðâ Runner counts (total jobs: 26)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
May 16, 2025
| ::std::unordered_set<cudaGraphNode_t> seen; | ||
| ::std::vector<cudaGraphNode_t> result; | ||
|
|
||
| for (cudaGraphNode_t node : nodes) |
Contributor
There was a problem hiding this comment.
Nitpick: we should reserve the space
Suggested change
| for (cudaGraphNode_t node : nodes) | |
| result.reserve(nodes.size()); | |
| for (cudaGraphNode_t node : nodes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some algorithms may reorder the edges in a CUDA graph, resulting in different topologies for the same code, and therefore prevent to update executable graphs.
Description
closes
Checklist