Add Python wrappers for c.parallel radix_sort API - #4353
Merged
NaderAlAwar merged 77 commits intoApr 21, 2025
Conversation
…T for now, and add missing ITEMS_PER_THREAD
…y info to avoid unnecessary instantiations
| return error; | ||
| } | ||
|
|
||
| CUresult cccl_device_ascending_radix_sort( |
Contributor
There was a problem hiding this comment.
Why not have single cccl_device_radix_sort which dispatches at run-time to cccl_device_radix_sort_impl<cub::SortOrder::Ascending> or cccl_device_radix_sort_impl<cub::SortOrder::Descending>?
Comment on lines
+707
to
+710
| cub::DoubleBuffer<indirect_arg_t> d_keys_buffer( | ||
| static_cast<indirect_arg_t*>(d_keys_in.state), static_cast<indirect_arg_t*>(d_keys_out.state)); | ||
| cub::DoubleBuffer<indirect_arg_t> d_values_buffer( | ||
| static_cast<indirect_arg_t*>(d_values_in.state), static_cast<indirect_arg_t*>(d_values_out.state)); |
Contributor
There was a problem hiding this comment.
Suggested change
| cub::DoubleBuffer<indirect_arg_t> d_keys_buffer( | |
| static_cast<indirect_arg_t*>(d_keys_in.state), static_cast<indirect_arg_t*>(d_keys_out.state)); | |
| cub::DoubleBuffer<indirect_arg_t> d_values_buffer( | |
| static_cast<indirect_arg_t*>(d_values_in.state), static_cast<indirect_arg_t*>(d_values_out.state)); | |
| indirect_arg_t key_arg1 = {d_keys_in}; | |
| indirect_arg_t key_arg2 = {d_keys_out}; | |
| cub::DoubleBuffer<indirect_arg_t> d_keys_buffer(&key_arg1, &key_arg2); | |
| indirect_arg_t val_arg1 = {d_values_in}; | |
| indirect_arg_t val_arg2 = {d_values_out}; | |
| cub::DoubleBuffer<indirect_arg_t> d_values_buffer(&val_arg1, &val_arg2); |
Contributor
Author
|
/ok to test 57bdd7d |
Contributor
🟨 CI finished in 1h 34m: Pass: 80%/5 | Total: 1h 06m | Avg: 13m 14s | Max: 34m 26s | Hits: 98%/324
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
🏃 Runner counts (total jobs: 5)
| # | Runner |
|---|---|
| 4 | linux-amd64-gpu-rtx2080-latest-1 |
| 1 | linux-amd64-cpu16 |
Contributor
Author
|
/ok to test e1f3250 |
Contributor
🟨 CI finished in 35m 42s: Pass: 80%/5 | Total: 1h 05m | Avg: 13m 07s | Max: 32m 00s | Hits: 98%/324
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
🏃 Runner counts (total jobs: 5)
| # | Runner |
|---|---|
| 4 | linux-amd64-gpu-rtx2080-latest-1 |
| 1 | linux-amd64-cpu16 |
NaderAlAwar
marked this pull request as ready for review
April 18, 2025 13:27
Contributor
🟨 CI finished in 21h 26m: Pass: 80%/5 | Total: 1h 05m | Avg: 13m 10s | Max: 32m 00s | Hits: 98%/324
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
🏃 Runner counts (total jobs: 5)
| # | Runner |
|---|---|
| 4 | linux-amd64-gpu-rtx2080-latest-1 |
| 1 | linux-amd64-cpu16 |
oleksandr-pavlyk
approved these changes
Apr 18, 2025
oleksandr-pavlyk
left a comment
Contributor
There was a problem hiding this comment.
Thank you @NaderAlAwar , LGTM!
Contributor
🟨 CI finished in 23m 07s: Pass: 66%/3 | Total: 33m 09s | Avg: 11m 03s | Max: 23m 07s
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 3)
| # | Runner |
|---|---|
| 3 | linux-amd64-gpu-rtx2080-latest-1 |
Contributor
🟩 CI finished in 17m 08s: Pass: 100%/3 | Total: 29m 26s | Avg: 9m 48s | Max: 17m 07s
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 3)
| # | Runner |
|---|---|
| 3 | linux-amd64-gpu-rtx2080-latest-1 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #3799
closes #2548
This should only be merged after #4350
Checklist