Change to allow cccl/c/parallel/unique_by_key.h to compile by C compiler - #4259
Conversation
1. Remove noexcept 2. Use uint64_t instead of unsigned long long (no required to allow compilation by C compiler, but adopted throughout to one day support compilation on Windows) 3. Add `#include <unique_by_key.h>` to `test_headers.c` test file
|
While at it, is there a reason by |
The reason I did it was to follow the order of the arguments in cccl/cub/cub/device/dispatch/dispatch_unique_by_key.cuh Lines 487 to 500 in 5d22600 However looking at the API I can see now that |
NaderAlAwar
left a comment
There was a problem hiding this comment.
LGTM, thanks @oleksandr-pavlyk
🟩 CI finished in 1h 11m: Pass: 100%/3 | Total: 1h 30m | Avg: 30m 09s | Max: 1h 10m | Hits: 95%/328
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
🏃 Runner counts (total jobs: 3)
| # | Runner |
|---|---|
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
| 1 | linux-amd64-cpu16 |
…ler (NVIDIA#4259) 1. Remove noexcept 2. Use uint64_t instead of unsigned long long (no required to allow compilation by C compiler, but adopted throughout to one day support compilation on Windows) 3. Add `#include <unique_by_key.h>` to `test_headers.c` test file
#include <unique_by_key.h>totest_headers.ctest fileDescription
closes #4258
Checklist