Implement fp properties - #4213
Merged
Merged
Conversation
Contributor
miscco
approved these changes
Mar 20, 2025
miscco
reviewed
Mar 20, 2025
| // __fp_exp_nbits_v | ||
|
|
||
| template <__fp_format _Fmt> | ||
| inline constexpr int __fp_exp_nbits_v = 0; |
Contributor
There was a problem hiding this comment.
I am wondering whether this is something we want to derive from numeric_limits
Contributor
Author
There was a problem hiding this comment.
There are some fundamental differences between the variables defined here and in numeric_limits. Example:
- the
numeric_limits::digitsdoes not specify if the type has the implict bit or not - the
numeric_limits::min_exponentandnumeric_limits::max_exponentare defined in a different way than the actual minimum and maximum exponent values
For these reasons I've decided to implement our own fp properties. We can then use them to simplify the implementation of numeric_limits by a lot
Contributor
Author
There was a problem hiding this comment.
Also, I am trying to avoid circular dependencies because __cccl_fp requires conversion rank which requires numeric_limits which requires __fp_from_storage which requires __cccl_fp
Contributor
|
/ok to test |
Contributor
🟩 CI finished in 2h 01m: Pass: 100%/162 | Total: 3d 08h | Avg: 29m 42s | Max: 1h 26m | Hits: 63%/252622
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 162)
| # | Runner |
|---|---|
| 113 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements internal fp properties module.