Repository navigation
Fix some issues with the AppImage launcher script - #5297
Merged
Merged
Conversation
Member
Author
|
I will wait for circleci to pass and then rebase it for stable. |
PhysSong
reviewed
Nov 1, 2019
ðĪ Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! ðĐ
Linux
Windows
macOS
ðĪ{"commit_sha": "816d81f69f3854e41489f66a7dd8a1c20a182566", "platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1173-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1173?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1176-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1176?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1174-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1174?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1177-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.753-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1177?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}} |
Reflexe
force-pushed
the
fix_appimage_wordsplitting
branch
from
November 1, 2019 06:00
bebf1dd to
816d81f
Compare
Member
Author
|
Tested it, working great. > mkdir "Directory With Spaces"
> mv ~/Downloads/lmms-1.2.0-rc6.753-linux-x86_64.AppImage Directory\ With\ Spaces/
> Directory\ With\ Spaces/lmms-1.2.0-rc6.753-linux-x86_64.AppImage
> cd Directory\ With\ Spaces
> ./lmms-1.2.0-rc6.753-linux-x86_64.AppImage
> ./lmms-1.2.0-rc6.753-linux-x86_64.AppImage --appimage-extract
> cd squashfs-root
> ./AppRun |
Reflexe
force-pushed
the
fix_appimage_wordsplitting
branch
from
November 1, 2019 06:37
816d81f to
40f8334
Compare
PhysSong
changed the title
PhysSong
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5284