Repository navigation
Fix crash due to calling QWidget::move from a non-GUI thread while ex… - #5293
Merged
Merged
Conversation
…porting tracks. Calling via QMetaObject::invokeMethod should be thread safe. Crash callstack: QWidget::move SongEditor::updatePosition Song::stop Song::stopExport ProjectRenderer::run QThreadPrivate::start
Contributor
Author
|
Bah, apparently signals are protected in old Qt 4… |
Cyp
force-pushed
the
fix-sporadic-export-crash
branch
from
October 31, 2019 09:03
2e7a9d3 to
2e90398
Compare
Member
|
@Cyp Thanks for your PR. Can you provide steps to trigger the crash so we can test this? |
Contributor
Author
|
It's not very reproducible — think it's only crashed 2 times so far for me — got the stack trace the second time. The steps are to open something with lots of tracks, press Ctrl+Shift+E and export the tracks. Maybe try to mess around with the GUI while it's exporting, not sure whether that's needed. Then repeat maybe a few hundred times until it crashes. |
Member
|
@Cyp Understood. I can't reproduce a crash, but the change makes sense and should be safe. Merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…porting tracks.
Using signals/slots instead should be thread safe.
Crash callstack:
QWidget::move
SongEditor::updatePosition
Song::stop
Song::stopExport
ProjectRenderer::run
QThreadPrivate::start