Repository navigation
fix(vscode): disclose first-folder chat scope in multi-root workspaces - #14925
Merged
WebReflection merged 4 commits intoOct 16, 2026
Merged
Conversation
abdulhusainahk
marked this pull request as ready for review
October 9, 2026 10:19
abdulhusainahk
force-pushed
the
fix/14882-workspace-scope-hint
branch
from
October 9, 2026 10:19
c95d931 to
6a199f2
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (34 files)
Reviewed by deepseek-v4.1-flash · Input: 115K · Output: 23.4K · Cached: 2.2M Review guidance: REVIEW.md from base branch |
Author
|
@WebReflection This first-folder workspace-scope notice is ready for maintainer review. The latest automated review reports No Issues Found, the unit/typecheck/visual jobs pass, and the contributor personal-review checklist is marked complete. The stale draft wording in the description is corrected; no code changed in this follow-up. Please review when you have capacity. The notice only explains existing sidebar scope and does not change session routing, permissions, or editor context. |
WebReflection
enabled auto-merge
October 16, 2026 13:41
WebReflection
approved these changes
Oct 16, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #14882.
Context
A multi-root window can look as though every Explorer folder belongs to the chat project, although the sidebar uses only the first workspace folder. Show that scope in the normal and onboarding empty states, name the folder using its VS Code display name, and explain the separate-window and Agent Manager alternatives without interrupting chat.
Implementation
The hint requests the current workspace scope when mounted and follows workspace-folder changes. Dismissal survives webview reloads without replacing unrelated saved webview state; a different first-folder path can show the hint again. Explicit project hosts, including Agent Manager, do not show the sidebar fallback notice.
This is disclosure only: session routing, permissions,
@discovery, and editor context are unchanged.Screenshots / Video
Actual components rendered in Chromium through Storybook; these are not native VS Code screenshots. The images linked here live on a separate evidence-only branch. Four Linux-generated story baselines from CI are included in the feature diff.
Light theme · 200px sidebar / long folder name · Onboarding
How to Test
Manual/local verification
All verification below was agent-executed on macOS with Bun 1.4.2.
KiloProviderand connection service with the repository's VS Code API harness. It exercised scope requests while disconnected, zero/one/multiple folders, reorder/removal events, explicit project/root overrides, reattachment, and disposal. All 11 assertions passed; the throwaway smoke was removed.bun test tests/unit/kilo-provider-acknowledgement.test.ts tests/unit/kilo-provider-worktree-context.test.ts tests/unit/kilo-provider-route-integration.test.ts tests/unit/kilo-provider-load-messages.test.ts tests/unit/kilo-provider-session-refresh.test.ts tests/unit/kilo-provider-open-session.test.ts: 173 passed, zero failed.bun run compilepassed, including host/webview typechecks, lint, bundling, CLI version/models/sandbox-worker smoke checks, and SDK preparation.bun run knip,bun run check-kilocode-change, and focused Prettier passed.VSCodeProviderin the existing recent-sessions fixture. The two affected test files now pass locally: 14 tests, zero failures. Host/webview typechecks, lint, and focused formatting passed.bun run test:unit: 6,874 passed, 2 skipped, 19 failed. All failures were inBrowserStream Chromium, beginning with a 10-second timeout and followed by closed-browser errors. No full local-suite pass is claimed, and no unrelated browser-stream code was changed.visual-regression-vscode-results(11540942845). No macOS screenshots were substituted.Remote CI
For follow-up commit
c95d9311b2da07c33bdabdcc98aaf9278ab6c11e, the extension unit job and webview visual-regression job both passed. Typechecks, Linux tests, docs build, links, and repository guards also passed. This is CI evidence, not personal or maintainer review.Reviewer test steps
Verification limits
Native VS Code interaction was not exercised. Substitute verification used the actual Storybook-rendered webview plus the real provider's request/event path in the VS Code API harness. The full local unit run had the BrowserStream failures disclosed above; follow-up remote unit and visual jobs passed. Independent native-speaker translation review was not performed.
Checklist
Get in Touch
Please reply here or mention @abdulhusainahk. AI-assisted implementation and verification. The contributor's personal-review checklist is marked complete; maintainer approval remains pending.