Repository navigation
Add DEVICE_TYPE environment variable to RUN_COMMAND - #598
Merged
Merged
Conversation
ichaoX
force-pushed
the
master
branch
2 times, most recently
from
September 18, 2022 13:41
327f056 to
94d8cd4
Compare
JoseExposito
requested changes
Sep 18, 2022
JoseExposito
left a comment
JoseExposito
left a comment
Owner
There was a problem hiding this comment.
Thanks for fixing the linter issue so fast!
In general the PR looks really good. I didn't remember that the device type was already in the protocol, so there is no need to change any other app.
I added a couple of minor comments, but it is almost ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #597