Repository navigation
Two finger pinch is often mis-recognised as two finger swipe. #541
Description
Describe the bug
Two finger pinch is easily misinterpreted as two finger swipe.
Expected behaviour
Make it easier to issue pinch gestures.
Looks like pinch recognition is too "strict".
Make a pinch if the relative distance between the fingers, or the angle of the line between the fingers, changes significantly, also if one finger does not move much absolutely.
Best: Add configuration items on thresholds to tell pinch and swipe apart.
Actual behaviour
I have two finger pinch and two finger swipe gestures configured. However, if I want to pinch, very easily touchegg does a swipe instead.
For three fingers this problem also appears, but less often.
I had the impression that with Touchégg version 1 it was much easier to actually trigger a two finger pinch correctly while also beeing able to trigger two finger swipe.
I use a touchscreen, not a touchpad. It is often just not easy to move both fingers at the same speed in opposite directions; often one finger does not move much but the other does.
Your environment
- Version of Touchégg: Run
touchegg --versionin the terminal to check the version:Touchégg v2.0.11.. - Operating System: Ubuntu, Fedora, Arch Linux...: Artix GNU/Linux.
- Desktop Environment: Gnome, KDE, Xfce...: No full blown desktop environment. Standalone window manager:
xfwm4oropenbox; standalone Panels:xfce4-panel. - Multitouch device: Lenovo m14t touchscreen.
Activity
JoseExposito commentedon Oct 21, 2021
I just released v2.0.12 including improvements on pinch detection.
Once it is available for your distro, could you test if the new version improved 2 finger pinch detection, please?
If not, a libinput record will help me to reproduce the issue locally. In order to generate one, execute this command:
$ sudo libinput record > recording.ymlAnd perform a pinch gesture. If the pinch is buggy, press control+C and attach the file here. Otherwise, press control+C and restart the command to keep the log as short as possible.
dreirund commentedon Oct 21, 2021
I just made it available for myself
It does not look better.
Here I attach the following:
libinput recordand corresponding output oftouchegg --client --debugfor a two finger swipe down that is correctly recognised as two finger swipe down,libinput recordand corresponding output oftouchegg --client --debugfor a two finger pinch out that is correctly recognised as two finger pinch out,libinput recordand corresponding output oftouchegg --client --debugfor a two finger pinch out that is wrongly correctly recognised as two finger swipe right,libinput recordand corresponding output oftouchegg --client --debugfor a two finger pinch in that is wrongly correctly recognised as two finger swipe left.Does that help?
touch-handler: Improve pinch detection when the fingers are placed ho…
JoseExposito commentedon Oct 24, 2021
Yes, thanks for the logs. There was a problem detecting pinch gestures when the fingers are placed horizontally or vertically.
Could you test this PR to discard any further issues, please? #544
dreirund commentedon Oct 24, 2021
touch-handler: Improve pinch detection when the fingers are placed ho…
JoseExposito commentedon Oct 25, 2021
Sure, I merged the lock file fix to simplify things a bit. Since you were using PKGBUILD to install the latest release, you should be able to change the source to point to the pull request branch:
Borrowed that like from AUR touchegg-git.
dreirund commentedon Oct 26, 2021
touch-handler: Improve pinch detection when the fingers are placed ho…