Skip to content

Rename throwErrorAsException to throwErrorM - #1032

Merged
carbolymer merged 1 commit into
masterfrom
mgalazyn/chore/rename-throwerrorasexception
Nov 24, 2025
Merged

carbolymer merged 1 commit into
masterfrom
mgalazyn/chore/rename-throwerrorasexception

Conversation

@carbolymer

@carbolymer carbolymer commented Nov 20, 2025 •

Copy link
Copy Markdown
Contributor

Changelog

- description: |
    Rename throwErrorAsException to throwErrorM
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-api
  # - cardano-api-gen
  # - cardano-rpc
  # - cardano-wasm

Context

throwErrorM and ErrorAsException seem to be a good replacements for CustomCliException and throwCliError. The difference is in Show constraint which does not appear to be used in cardano-cli.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer
carbolymer enabled auto-merge November 24, 2025 10:15
@carbolymer
carbolymer added this pull request to the merge queue Nov 24, 2025
Merged via the queue into master with commit c2cf462 Nov 24, 2025
40 of 44 checks passed
@carbolymer
carbolymer deleted the mgalazyn/chore/rename-throwerrorasexception branch November 24, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants