You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Notifications repeatedly notify for the same tweet #292
Ah, that's probably something to do with the fix for #147 where we overlap our requests to try and reduce the chance of missing tweets due to eventual consistency.
I tested with "Every" (since I don't get 5 tweets every 2 minutes - which is our polling time) and it didn't come back after the patch. But the behaviour before the patch and examining the code was definitely caused by it notifying when the same tweet came in due to overlapping requests, even though you had seen that tweet before.
If it's still happening after the patch then it would help if there are any patterns that you can see (Always the same tweet, even after you read some? Always the latest tweet when nothing new appears but changes when a new tweet comes in? Numbers don't match what Cawbird is reporting?)
If you had a multiple of five tweets unread and then each poll returned overlapping tweets but no new tweets then the old code would have kept notifying every two minutes. The moment a new unread tweet came in then it would have had 5n+1 tweets and so the "is divisible by zero" check wouldn't have passed and it wouldn't notify until you were at 5n+5.
But now we shouldn't even get that far because the overlapping tweet is marked as "not a new unread tweet" and so it returns before it notifies.
It should work if you copy the build/data/ directory and set the paths correctly. You'll need to copy and install the schema at some point. Unless you're planning to always install the latest Cawbird package and piggy-back all of its libraries and config to make the custom executable work.
When will this fix make it to a release? I am a stupid stupid idiot and only know how to let Manjaro take care of things for me, so my guess is that 1.3.3 needs to exist for me to receive this fix.
Soon-ish. I've had some other priorities and there have been a few things that were found, fixed and getting a bit of testing that delayed my earlier release plans.
Activity
IBBoard commentedon Jan 20, 2021
Ah, that's probably something to do with the fix for #147 where we overlap our requests to try and reduce the chance of missing tweets due to eventual consistency.
I'll have to look at how we handle notifications.
[-]Notifications dont work properly[/-][+]Notifications repeatedly notify for the same tweet[/+]philipzae commentedon Jan 20, 2021
Just to be clear, it wasn't limited to just the same tweet, as I would set it to 'Stack 5' and that notification would also popup multiple times.
IBBoard commentedon Jan 21, 2021
I tested with "Every" (since I don't get 5 tweets every 2 minutes - which is our polling time) and it didn't come back after the patch. But the behaviour before the patch and examining the code was definitely caused by it notifying when the same tweet came in due to overlapping requests, even though you had seen that tweet before.
If it's still happening after the patch then it would help if there are any patterns that you can see (Always the same tweet, even after you read some? Always the latest tweet when nothing new appears but changes when a new tweet comes in? Numbers don't match what Cawbird is reporting?)
philipzae commentedon Jan 21, 2021
I didn't have over 5 tweets with 2 minutes either, but the 5 tweets notification still kept popping up for the maybe 1 tweet which was there. ð
The only thing that I could say is that I wasn't at the top of the timeline and don't have 'auto scroll on new tweets' enabled.
IBBoard commentedon Jan 22, 2021
If you had a multiple of five tweets unread and then each poll returned overlapping tweets but no new tweets then the old code would have kept notifying every two minutes. The moment a new unread tweet came in then it would have had 5n+1 tweets and so the "is divisible by zero" check wouldn't have passed and it wouldn't notify until you were at 5n+5.
But now we shouldn't even get that far because the overlapping tweet is marked as "not a new unread tweet" and so it returns before it notifies.
philipzae commentedon Jan 22, 2021
Tried to test the patch to see if it works for all scenarios by building master, but got this error.
IBBoard commentedon Jan 23, 2021
That's because the settings schema was updated recently, but your installed schema doesn't include the new fields. Try the "GSettings in memory" command from the README.
Add a variation on the "wrong schema" error
philipzae commentedon Jan 24, 2021
Doubt this will work for me as I build cawbird in a VM and copy the executable to my host OS.
IBBoard commentedon Jan 24, 2021
It should work if you copy the
build/data/directory and set the paths correctly. You'll need to copy and install the schema at some point. Unless you're planning to always install the latest Cawbird package and piggy-back all of its libraries and config to make the custom executable work.Asday commentedon Apr 24, 2021
When will this fix make it to a release? I am a stupid stupid idiot and only know how to let Manjaro take care of things for me, so my guess is that 1.3.3 needs to exist for me to receive this fix.
IBBoard commentedon Apr 24, 2021
Soon-ish. I've had some other priorities and there have been a few things that were found, fixed and getting a bit of testing that delayed my earlier release plans.
Asday commentedon Apr 24, 2021
Aight beast, thanks for both the quick reply and for dealing with my pestilent presence. I'm excited for the release.