Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Missing edit profile icon on Pinephone #259

Closed

Description

@justinesmithies

Describe the bug
When using Cawbird on the Pinephone with Arch the user profile menu is off screen to the right which clips the edit profile icon.

To Reproduce
Steps to reproduce the behavior:

  1. Click on user profile image.
  2. pop up window off screen on the right

Expected behavior
To be able to see the whole of the pop up window on the pinephone.

Screenshots
If applicable, add screenshots to help explain your problem.

System details:

  • OS: Arch Arm
  • Version: latest
  • Package type: cawbird-git from the Arch AUR repo

Additional context
Add any other context about the problem here.

Running G_MESSAGES_DEBUG=cawbird cawbird can give useful debug output.

Activity

  1. added
    bugSomething isn't working
    designUI and design issues
    on Dec 31, 2020
  2. IBBoard commented on Dec 31, 2020

    @IBBoard
    Owner
  3. IBBoard commented on Jan 1, 2021

    @IBBoard
    Owner

    Just doing a quick investigation and test andâ€Ķ I think there might be limited amounts that we can do with this because of various problems inherent in GTK "popovers".

    If I put a really long name in then it gets quite wide:

    Screenshot from 2021-01-01 19-21-00

    And if I shrink the window then the popover doesn't shrink (and because of an old, known GTK issue that they never fixed, that cropping will stay in X):

    Screenshot from 2021-01-01 19-22-13

    There might still be some way to work around it other than reducing margins, but we'll have to see.

  4. added a commit that references this issue on Jan 1, 2021
  5. IBBoard commented on Jan 1, 2021

    @IBBoard
    Owner

    I've put in some tweaks, but it may not fix it. Are you able to build a new version from "master" and test?

    I've also tried size requests on the popover (whether when showing the popover or when the window gets a size allocation) and it doesn't seem to honour those, so we don't appear to be able to say "no bigger than the window".

    I also tried setting Gtk.PopoverConstraint.WINDOW which should "Constrain the popover to the boundaries of the window that it is attached to" andâ€Ķ it doesn't. It still overflows and gets cropped.

    https://valadoc.org/gtk+-3.0/Gtk.PopoverConstraint.html

  6. added a commit that references this issue on Jan 3, 2021
  7. IBBoard commented on Jan 3, 2021

    @IBBoard
    Owner

    Okay, it's not perfect, but hopefully that latest commit makes things a bit more workable.

    We've also now got a more sane default value for maximum name lengths before truncating, because 40 characters is huge!

    Can someone on mobile test this?

  8. ahoneybun commented on Jan 4, 2021

    @ahoneybun

    Let me see if I can build it from master or is this from the latest release?

  9. ahoneybun commented on Jan 4, 2021

    @ahoneybun

    I built it on the PinePhone on Arch though it seems that it can't use Firefox to get me the key to log in so I need to get around that.

  10. IBBoard commented on Jan 7, 2021

    @IBBoard
    Owner

    I've seen comments on Twitter that v1.3 is pretty much as good as it'll get on PinePhone/Phosh (without the libhandy redesign) so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdesignUI and design issues

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions