Repository navigation
Use ru{} in favor of rs{} where it makes sense - #873
Merged
HowardHinnant merged 1 commit intoMar 11, 2025
Merged
Conversation
Owner
|
Thanks, nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #872
I've swapped out
rsforrueverywhere I mentioned in #872 except for in%Cwhere apparently century can be meaningfully negative. (Normally I'd wait for you to comment before doing a PR but it seemed like a POC was an easier way to see if I was missing anything with my idea)I also went ahead and added some extra tests related to this. The majority of the new tests would not have passed before this change (meaning they would have previously performed a successful parse in some weird cases).
The test for a negative year in
%cfailing is dependent on the decision of #871, but reflects the current state of things.