Repository navigation
improve test_fail.sh - #862
Merged
Merged
Conversation
This is a simple shell script using no bash functionalty. Closes: #854
the default `exit` value is 0 so we do not need to explicitly call it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first change is a bugfix -- bash is not available on any system and the path to it is not always the same.
Calling
/usr/bin/env bashis a good fix for that, but the script is not using any bash-specific stuff so I have made it call/bin/shwhich is a standard location for the POSIX sh.In the second commit I have simplified the code while keeping the functionality: