Skip to content

Fix: show Rosetta warning when Rosetta is not installed - #5772

Merged
flavioislima merged 2 commits into
mainfrom
fix/rosetta-check-warning
Aug 5, 2026
Merged

Fix: show Rosetta warning when Rosetta is not installed#5772
flavioislima merged 2 commits into
mainfrom
fix/rosetta-check-warning

Conversation

@flavioislima

@flavioislima flavioislima commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

We had the code to check for if rosetta was installed or not on macOS but its was not working anymore after some regression, I am not sure, maybe never worked. I tested this one now and it works fine. I got the issue when updated to macOS 27 beta.

@flavioislima flavioislima changed the title fix: show Rosetta warning when Rosetta is not installed Fix: show Rosetta warning when Rosetta is not installed Jul 23, 2026
@flavioislima
flavioislima requested review from a team, BananaWorks07, CommandMC, arielj, biliesilva and imLinguin and removed request for a team July 23, 2026 17:12
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 23, 2026
@flavioislima flavioislima added this to the 2.23.0 milestone Jul 23, 2026
flavioislima
flavioislima commented Jul 23, 2026
View reviewed changes
Comment thread src/backend/utils.ts Outdated
@flavioislima flavioislima self-assigned this Jul 23, 2026
CommandMC
CommandMC reviewed Jul 23, 2026
View reviewed changes

@CommandMC CommandMC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note about this: macOS 27 apparently has on-the-fly translation of x86_64 without Rosetta (see the "Important" note here). I don't know if this also applies for our use case though

Comment thread src/backend/utils.ts Outdated
arielj
arielj reviewed Jul 24, 2026
View reviewed changes
Comment thread src/backend/utils.ts Outdated
@CommandMC CommandMC linked an issue Jul 25, 2026 that may be closed by this pull request
Info Dialog when Rosetta 2 is missing #5774
Closed
@flavioislima

flavioislima commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

One thing to note about this: macOS 27 apparently has on-the-fly translation of x86_64 without Rosetta (see the "Important" note here). I don't know if this also applies for our use case though

I'm on 27 beta and I needed to install it. That is why I found the issue in heroic since all my games stopped working after the update.

@flavioislima
flavioislima merged commit 9a1b0af into main Aug 5, 2026
10 checks passed
@flavioislima
flavioislima deleted the fix/rosetta-check-warning branch August 5, 2026 12:52
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CommandMC CommandMC CommandMC approved these changes
@BananaWorks07 BananaWorks07 Awaiting requested review from BananaWorks07 BananaWorks07 is a code owner automatically assigned from Heroic-Games-Launcher/development
@biliesilva biliesilva Awaiting requested review from biliesilva biliesilva is a code owner automatically assigned from Heroic-Games-Launcher/development
@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin is a code owner automatically assigned from Heroic-Games-Launcher/development
@arielj arielj Awaiting requested review from arielj

Assignees

@flavioislima flavioislima

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Milestone

2.23.0

Development

Successfully merging this pull request may close these issues.

Info Dialog when Rosetta 2 is missing

3 participants

@flavioislima @arielj @CommandMC