Repository navigation
[UX] Download known fixes even before downloading a game - #5409
Merged
Merged
Conversation
arielj
requested review from
a team,
BananaWorks07,
CommandMC,
biliesilva,
flavioislima and
imLinguin
and removed request for
a team
March 14, 2026 02:03
arielj
commented
Mar 14, 2026
| rStream.pipe(hash) | ||
| await finished(rStream) | ||
| return hash.digest('hex') | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I moved this to utils/releases.ts so it can be shared between modules, since it's only used to check md5 for this releases feature only
arielj
commented
Mar 14, 2026
| } | ||
| } | ||
|
|
||
| async function downloadFixesFor(appName: string, runner: Runner) { |
Collaborator
Author
There was a problem hiding this comment.
we don't need any of that now during the game download
arielj
commented
Mar 14, 2026
| if (existsSync(fixFilePath)) { | ||
| rmSync(fixFilePath) | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
we don't need to delete any file now during uninstall
arielj
commented
Mar 14, 2026
| InstallParams, | ||
| InstallPlatform, | ||
| KnowFixesInfo, | ||
| KnownFixesInfo, |
Collaborator
Author
There was a problem hiding this comment.
there was a typo before
arielj
commented
Mar 14, 2026
|
|
||
| export const hasKnownFixes = (appName: string, runner: Runner) => { | ||
| const [knownFixes, setKnownFixes] = useState<KnowFixesInfo | null>(null) | ||
| export const useKnownFixes = (appName: string, runner: Runner) => { |
Collaborator
Author
There was a problem hiding this comment.
react was complaining about this name
CommandMC
reviewed
Mar 15, 2026
arielj
force-pushed
the
known-fixes-before-install
branch
from
September 11, 2026 03:13
2387375 to
a69d7fd
Compare
CommandMC
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the logic used to fetch game known fixes. Instead of downloading the info per-game during the game's installation, we now download a json file with all the known fixes at boot from https://github.com/Heroic-Games-Launcher/known-fixes/blob/main/known_fixes.json (it's only 16kb and it's only updated eventually only if we add new fixes, so nothing to worry at this point)
This has a lot of advantages both for the end user and for us:
Use the following Checklist if you have changed something on the Backend or Frontend: