Repository navigation
fix(signal): honor wildcard in inbound allowlists - #5472
Merged
Merged
Conversation
Re-bin
force-pushed
the
fix/signal-wildcard-allowlist
branch
from
September 3, 2026 06:03
fc91e39 to
97b8611
Compare
Re-bin
force-pushed
the
fix/signal-wildcard-allowlist
branch
from
September 3, 2026 10:02
97b8611 to
d023e07
Compare
Re-bin
approved these changes
Sep 3, 2026
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Signal inbound DM and group checks now honor the documented wildcard allowlist without broadening access unless the operator explicitly configured it.
Signal regression tests and all current-head CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*in Signal DM and group allowlist policy gatesReproduction
Configure Signal with wildcard allowlists:
{ channels: { signal: { enabled: true, phoneNumber: +10000000000, dm: { enabled: true, policy: allowlist, allowFrom: [*] }, group: { enabled: true, policy: allowlist, allowFrom: [*], requireMention: false } } } }Send the bot a DM and a group message from identifiers not explicitly listed.
Actual behavior
The Signal-specific policy gate treats
*as a literal identifier:the channel-wide wildcard check with an empty payload, losing the original
message content.
*.Expected behavior
*should retain the channel-wide allowlist meaning of allowing every senderor group, and the original message content should reach the inbound bus.
Testing
uv run --no-sync pytest nanobot/channels/signal/tests/test_signal_channel.py nanobot/channels/signal/tests/test_signal_markdown.py -q— 190 passeduv run --no-sync ruff check nanobot/channels/signal/runtime.py nanobot/channels/signal/tests/test_signal_channel.pyuv run --no-sync basedpyright nanobot/channels/signal/runtime.py nanobot/channels/signal/tests/test_signal_channel.pygit diff --check