Skip to content

fixed to get displayInfo in Android Q with No flags - #3573

Closed
issess wants to merge 1 commit into
Genymobile:devfrom
issess:dev
Closed

issess wants to merge 1 commit into
Genymobile:devfrom
issess:dev

Conversation

@issess

@issess issess commented Nov 9, 2022 •

Copy link
Copy Markdown
Contributor

Hi, I fixed a bug to get displayInfo in fallback mode on Android Q OS.

https://cs.android.com/android/_/android/platform/frameworks/base/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7

after this commit, It was changed dump message from
sb.append(", displayId ");
to
sb.append("", displayId ");

so, I removed \" to support all android version.

please review this bug patch.

rom1v pushed a commit that referenced this pull request Nov 12, 2022
The DisplayInfo dump format has slightly changed in AOSP:
<https://android.googlesource.com/platform/frameworks/base.git/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7>

PR #3573 <#3573>
Ref #3416 <#3416>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v

rom1v commented Nov 12, 2022 •

Copy link
Copy Markdown
Collaborator

Thank you, LGTM 👍

Merged into dev: 597703b

@rom1v rom1v closed this Nov 12, 2022
rom1v pushed a commit that referenced this pull request Nov 12, 2022
The DisplayInfo dump format has slightly changed in AOSP:
<https://android.googlesource.com/platform/frameworks/base.git/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7>

PR #3573 <#3573>
Ref #3416 <#3416>

Signed-off-by: Romain Vimont <rom@rom1v.com>
Linux4 pushed a commit to Linux4/scrcpy that referenced this pull request Sep 5, 2025
scrcpy v1.25

Changes since v1.24:
 - Adapt copy-paste internals for Android 13 (Genymobile#3497)
 - Add support for high-precision scrolling (Genymobile#3363, Genymobile#3369)
 - Add desktop entry files for Linux (Genymobile#295, Genymobile#296, Genymobile#748, Genymobile#1636, Genymobile#3351)
 - Add bash and zsh autocompletion for -s/--serial (Genymobile#3522, Genymobile#3523)
 - Use current adb port (if any) for --tcpip (Genymobile#3591, Genymobile#3592)
 - Add fallback to get display information on some devices (Genymobile#3416, Genymobile#3573)
 - Fix click behavior when --forward-all-clicks is set (Genymobile#3568, Genymobile#3579)
 - Fix support for non-ASCII characters in window title (Genymobile#2932, Genymobile#3547)
 - Fix getDisplayIds() crash on some versions of Android 13 beta (Genymobile#3446)
 - Upgrade platform-tools to 33.0.3 (adb) in Windows releases
 - Upgrade FFmpeg to 5.1.2 in Windows 64-bit releases
 - Upgrade SDL to 2.26.1 in Windows releases
 - Various technical fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants