Skip to content

Sketcher: Adding point-on-object for drag on curves - #31295

Merged
maxwxyz merged 2 commits into
FreeCAD:mainfrom
Reqrefusion:pointonobjectonarc
Aug 8, 2026
Merged

Sketcher: Adding point-on-object for drag on curves#31295
maxwxyz merged 2 commits into
FreeCAD:mainfrom
Reqrefusion:pointonobjectonarc

Conversation

@Reqrefusion

@Reqrefusion Reqrefusion commented Jul 12, 2026

Copy link
Copy Markdown
Member

I was so focused on leaving out the tangent with Arc and Circle that I forgot that there could be point on object for them. This PR adds to that. Thanks to @Roy-043 for reminding me.

  • This PR is not unverified AI output, I take responsibility for it, and all communication from my side in this PR is done by me personally.

Issues

Before and After Images

@github-actions github-actions Bot added Status: Needs triage Missing triage Mod: Sketcher Related to the Sketcher Workbench Language: C++ labels Jul 12, 2026
@FEA-eng

FEA-eng commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

This makes it work with circular arcs, but there are also ellipses and elliptical/hyperbolic/parabolic arcs. Could you add them too? And possibly also splines.

@Reqrefusion

Reqrefusion commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

Oh yes, they had them too, right XD I'll check them out.

@Reqrefusion
Reqrefusion force-pushed the pointonobjectonarc branch 2 times, most recently from 5483a74 to c4fd049 Compare July 12, 2026 20:18
@Reqrefusion Reqrefusion changed the title Sketcher: Adding point-on-object for drag on arcs and circles. Sketcher: Adding point-on-object for drag on curves Jul 12, 2026
@Reqrefusion

Reqrefusion commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

@FEA-eng It should now work for all curves.

@maxwxyz maxwxyz added Requires: Testing The PR needs testing by users and developers Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other... Requires: Code Review The PR requires code to be reviewed and removed Status: Needs triage Missing triage labels Jul 13, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Jul 13, 2026
@maxwxyz maxwxyz added this to the 26.3 milestone Jul 13, 2026
FEA-eng
FEA-eng approved these changes Jul 13, 2026
View reviewed changes

@FEA-eng FEA-eng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwxyz Tested, works as expected

@maxwxyz maxwxyz added Approved: Tested The PR was manually tested and approved and removed Requires: Testing The PR needs testing by users and developers labels Jul 13, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jul 13, 2026
@maxwxyz
maxwxyz enabled auto-merge (squash) August 8, 2026 10:45
@maxwxyz
maxwxyz merged commit 2a511bd into FreeCAD:main Aug 8, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Merge Queue Aug 8, 2026
This was referenced Aug 22, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@FEA-eng FEA-eng FEA-eng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved: Tested The PR was manually tested and approved Language: C++ Mod: Sketcher Related to the Sketcher Workbench Requires: Code Review The PR requires code to be reviewed Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other...

Projects

Merge Queue
Status: Done

Milestone

26.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Reqrefusion @FEA-eng @maxwxyz