Skip to content

Keep the panel capsule under the whole Bot tab - #474

Merged
Fei2411 merged 1 commit into
devfrom
fix/472-tab-capsule
Oct 23, 2026
Merged

Fei2411 merged 1 commit into
devfrom
fix/472-tab-capsule

Conversation

@Fei2411

@Fei2411 Fei2411 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Issue

Fixes #472

What changed / 改了什么

Bug fixed: after a click from a browser tab back to the Bot's own tab, the highlight capsule covered only the Bot's mark and left its name outside. The capsule was measured while the name still started its max-width: 0 animation, and the observer that corrects it watched only the strip.

  • The name fades in at its full width, so the measure sees the final layout and the capsule's springs land on it.
  • The observer also watches the active tab, so the capsule follows any later change of the tab's width.

Changelog

The highlight under the Bot's tab in the side panel covers the whole tab again after you come back from a browser tab.

How I checked it / 怎么验证的

  • npm test (in ds-bot/): 919 pass, 0 fail, 1 skip
  • node scripts/build-client.mjs --check
  • npm run lint
  • Desktop app from source with the mock model: after the click back to the Bot tab, the capsule's right edge missed the tab's by 28.9 px on dev (from 100 ms on) and by 0.1 px with this change, at 0, 100, 300 ms and 1 s.
  • Screenshot attached, for interface changes / 界面改动已附截图

Devin Review

Opening a Bot's tab back from its browser showed the name sliding in from
zero width; the capsule measured the tab before the name existed and the
strip's ResizeObserver only watched the whole strip, so it never followed
(#472). The name now fades in at its final width, so the measure lands on
the settled layout, and the observer watches the active tab itself for
any later width change.
@Fei2411

Fei2411 commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Desktop app, mock model, 1 s after the click back to the Bot tab. Before (dev), then after.

before

after

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T10:29:20.037791Z 55f9af8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@Fei2411
Fei2411 merged commit ba91824 into dev Oct 23, 2026
13 checks passed
@Fei2411
Fei2411 deleted the fix/472-tab-capsule branch October 23, 2026 10:34
@Fei2411 Fei2411 mentioned this pull request Oct 23, 2026
1 task done
Fei2411 added a commit that referenced this pull request Oct 23, 2026
elonnzhang pushed a commit to elonnzhang/DeepSeek-Bot that referenced this pull request Oct 23, 2026
They merged after the 0.2.1 changelog was written; the release now includes them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant