Repository navigation
Fix trigger conditions - #107
Merged
Merged
Conversation
Signed-off-by: Oliver Kopp <kopp.dev@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Diapolo10
approved these changes
Sep 29, 2023
Diapolo10
left a comment
Diapolo10
left a comment
Owner
There was a problem hiding this comment.
Thanks, apparently I forgot to update this from my template project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At #105 and https://github.com/orgs/community/discussions/26698#discussioncomment-7094600 it was reported, that the unit tests were not triggered on a pull request.
The reason was that the trigger for a pull request was not active. The trigger
pull_requestis used for PRs - see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request for detailsNote that the workflow https://github.com/Diapolo10/iplib3/blob/main/.github/workflows/codeql-analysis.yml has the correct triggers.
I also added
workflow_dispatchto enable manual triggering.